Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RF] Crash in RooStats::ToyMCSample::GenerateToyData #11565

Closed
1 task done
TomasDado opened this issue Oct 14, 2022 · 1 comment · Fixed by #15902
Closed
1 task done

[RF] Crash in RooStats::ToyMCSample::GenerateToyData #11565

TomasDado opened this issue Oct 14, 2022 · 1 comment · Fixed by #15902
Assignees
@guitargeek
Labels
bug in:RooFit/RooStats

Comments

@TomasDado
Copy link

  • Checked for duplicates

Describe the bug

A segmentation violation is encountered when trying to run fit on toys during the toy generation.

To Reproduce

To reproduce the crash, please use the attached (minimal) code and the ROOT file with the RooWorkspace inside: link to cernbox

Setup

Tested on
ROOT Version: 6.27/01
Built for linuxx8664gcc on Jul 18 2022, 09:11:00
From heads/master@ffdbbb6d

as well as
LCG_101 x86_64-centos7-gcc8-opt

Additional context

Note that the code here tries to reproduce what is done in a bigger framework, It is entirely possible that we are doing something dumb and this is not an actual bug in GenerateToyData, but it is interestingly seen only for "gammas" NPs (i.e. one NP per bin)
@TomasDado TomasDado added the bug label Oct 14, 2022
ferdymercury added a commit to ferdymercury/root that referenced this issue Jun 21, 2024
@ferdymercury
[RF] prevent accessing empty vector
d2b85ba 
Fixes root-project#11565
@ferdymercury ferdymercury mentioned this issue Jun 21, 2024
Merged
2 tasks
@ferdymercury
Copy link
Collaborator

ferdymercury commented Jun 21, 2024 •
edited
Loading

Fix here: #15902

Compilable reproducer is attached.
MWE.zip

guitargeek pushed a commit to ferdymercury/root that referenced this issue Aug 2, 2024
@ferdymercury @guitargeek
[RF] prevent accessing empty vector
cf886ff 
Fixes root-project#11565
guitargeek pushed a commit that referenced this issue Aug 2, 2024
@ferdymercury
[RF] Check for empty global observables in generateSimGlobal
e9fffa9 
Closes #11565.
guitargeek pushed a commit to guitargeek/root that referenced this issue Aug 2, 2024
@ferdymercury @guitargeek
[RF] Check for empty global observables in generateSimGlobal
d6520bf 
Closes root-project#11565.
guitargeek pushed a commit that referenced this issue Aug 3, 2024
@ferdymercury @guitargeek
[RF] Check for empty global observables in generateSimGlobal
ba23149 
Closes #11565.
silverweed pushed a commit to silverweed/root that referenced this issue Aug 14, 2024
@ferdymercury @silverweed
[RF] Check for empty global observables in generateSimGlobal
a078481 
Closes root-project#11565.
silverweed pushed a commit to silverweed/root that referenced this issue Aug 19, 2024
@ferdymercury
[RF] Check for empty global observables in generateSimGlobal
31ce3d0 
Closes root-project#11565.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guitargeek guitargeek

Labels
bug in:RooFit/RooStats
Projects
No open projects
Fixed in 6.32.04
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[RF] prevent accessing empty vector (histOut) ferdymercury/root
3 participants
@guitargeek @ferdymercury @TomasDado