[root-config] Fix --git-revision:

[Axel-Naumann]

Fixes #14229

This Pull request:

Changes or fixes:

Checklist:

• tested changes locally
• updated the docs (if necessary)

This PR fixes #

[phsft-bot]

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

[pcanal]

Do we have a test for this?

[github-actions]

Test Results

       10 files         10 suites   2d 0h 1m 23s ⏱️
  2 485 tests   2 483 ✔️ 0 💤 2 ❌
23 773 runs  23 771 ✔️ 0 💤 2 ❌

For more details on these failures, see this check.

Results for commit 1e08ede.

♻️ This comment has been updated with latest results.

[ferdymercury]

A test would be a good idea, yeah.

[phsft-bot]

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

[phsft-bot]

Build failed on mac12arm/cxx20.
Running on 194.12.161.128:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

[guitargeek]

@phsft-bot build

[phsft-bot]

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

[guitargeek]

Thanks for the fix and the review!

I will take care of backporting this to the 6.30 branch.

[ferdymercury]

Thanks!
Is there a GitHub issue somewhere where we could collect 'future tests' ideas, so that they do not get lost inside issues?

Like:

• [root-config] Fix --git-revision: #14231 (comment)
• Mention root.cern instead of root.cern.ch #14275 (comment)
• [IO] Prevent infinite loop in TFile::ls #13217
• thisroot.sh does not recognize bash when running in qemu-x86_64 #14085

[guitargeek]

No, we don't have such an issue, but I think it's a great idea to have it. We can mark it also with the "good for new contributors" label, because writing tests is always a good way to get familiar with the codebase. Can you open such an issue, please? 🙏