add functions for tweet embedding and threading #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the threading function needs a leaf of a thread to run, which is a problem for ongoing threads, where continuous polling of threads would be a problem. I also have a version the can start from the root or mid thread and continue to the last published leaf. Is it worth making the threading to be able to traverse in either direction? |
Closed
|
This PR might close #164. I think it makes sense to look up and down. |
|
Thanks @yonicd finally it can be merged |
|
i totally forgot about this PR (2 yrs is a long time :) ). thanks for merging it! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.