Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use TWIT_paginate_cursor in more places #552

Merged
merged 18 commits into from
Apr 2, 2021
Merged

Use TWIT_paginate_cursor in more places #552

merged 18 commits into from
Apr 2, 2021

Conversation

hadley
Copy link
Member

@hadley hadley commented Apr 1, 2021

Replacing hand-rolled pagination code. This increases consistency and is one step towards #510.

@hadley hadley requested a review from llrs April 1, 2021 17:52
@hadley
Copy link
Member Author

hadley commented Apr 1, 2021

@llrs I'm having a hard time getting collections to work, because their APIs are so different. What do you think about just getting rid of lookup_collections() and get_collections()? I'd never heard of a twitter collection before this, and my googling doesn't find much about them.

llrs
llrs approved these changes Apr 2, 2021
View reviewed changes
Copy link
Member

@llrs llrs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding more API references I missed.

With this PR I finally I understood how useful TWIT_paginate_cursor is.

Most comments are to increase the number of results returned on each page to minimize the number of requests.

About lookup_collections() and get_collections(), I agree to deprecate. Twitter itself did the same, so I don't see any value on keeping them: https://developer.twitter.com/en/docs/twitter-for-websites/timelines/guides/collection

R/http.R Show resolved Hide resolved
R/lists_members.R Outdated Show resolved Hide resolved
R/lists_memberships.R Outdated Show resolved Hide resolved
R/lists_subscribers.R Outdated Show resolved Hide resolved
R/lists_subscriptions.R Outdated Show resolved Hide resolved
@hadley hadley merged commit 0790d64 into master Apr 2, 2021
@hadley hadley deleted the more-paginate-cursor branch April 2, 2021 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llrs llrs llrs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hadley @llrs