-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated get_csid() to handle new ChemSpider API #165
Conversation
Codecov Report
@@ Coverage Diff @@
## master #165 +/- ##
=====================================
Coverage 0% 0%
=====================================
Files 18 18
Lines 1668 1658 -10
=====================================
+ Misses 1668 1658 -10
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks you for your contribution! I made a few minor comments before merging.
Thanks, this is much more elegant. Tested, works. Co-Authored-By: stitam <49147718+stitam@users.noreply.github.com>
R CMD check succeeded, I am clueless with this Travis error, any help would be appreciated. |
Don't know what's wrong with travis, but this looks really good! |
A lot of files seem like they changed, it's because of the devtools::document(). I only worked with the chemspider.R and DESCRIPTION files.