-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added CAS, EC, GSBL, RTECS search options to get_etoxid() #241
Conversation
Codecov Report
@@ Coverage Diff @@
## master #241 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 19 19
Lines 1672 1685 +13
======================================
- Misses 1672 1685 +13
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't tested it out, but looks great in format. I think there needs to be a bit more documentation for the lesser-known options for from=
.
Sorry for the mess. Don't know why travis check is failing. Could it be because of man/nist_ri.Rd? It doesn't seem to be built. |
According to log it has to do with |
It only fails on the development build of R. It passes with the release build of R. I can't figure out why either. |
I've added features to query the ETOX data-base by CAS, EC, GSBL, RTECS numbers in addition to the already existing option to search for names (as discussed in #237).
NB: I've added examples and tests for all the new features except for RETCS-numbers, which seems to be a proprietary format, for which I only found rather old publications. I left it there nonetheless.
PR task list:
devtools::document()