Use pytest-httpbin to run the test suite locally #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the use of online httpbin with the local httpbin instance provided via pytest-httpbin package. This makes the test suite offline, effectively removing the need for pytest-network as well. Fixes ross#136
Closed
ross
reviewed
Aug 11, 2023
| zipp==3.15.0 | ||
| zipp==3.16.2 | ||
| zope.event==5.0 | ||
| zope.interface==6.0 |
There was a problem hiding this comment.
These updated with ./script/update-requirements? When I run it locally on this branch I get a few diffs:
coho:requests-futures ross$ git diff
diff --git a/requirements-dev.txt b/requirements-dev.txt
index 330d5b6..c652801 100644
--- a/requirements-dev.txt
+++ b/requirements-dev.txt
@@ -3,7 +3,6 @@ Jinja2==3.1.2
MarkupSafe==2.1.3
PyYAML==6.0.1
Pygments==2.16.1
-SecretStorage==3.3.3
Werkzeug==2.3.6
attrs==23.1.0
black==23.7.0
@@ -14,7 +13,6 @@ build==0.10.0
cffi==1.15.1
click==8.1.6
coverage==7.2.7
-cryptography==41.0.3
decorator==5.1.1
docutils==0.20.1
flasgger==0.9.7.1
@@ -26,7 +24,6 @@ iniconfig==2.0.0
isort==5.12.0
itsdangerous==2.1.2
jaraco.classes==3.3.0
-jeepney==0.8.0
jsonschema-specifications==2023.7.1
jsonschema==4.19.0
keyring==24.2.0There was a problem hiding this comment.
Yes, that's how I updated them. I wonder if the difference could be because of different Python version — I ran it with 3.11.4.
There was a problem hiding this comment.
Doesn't appear to be:
(env) coho:requests-futures ross$ python --version
Python 3.11.4Maybe OS. I'm on OSX. Anyway. Just seemed like odd requirements, but probably not hurting anything, I guess.
There was a problem hiding this comment.
Ah yes, it's probably because I'm running on Linux ;-).
ross
approved these changes
Aug 11, 2023
|
Thanks! |
|
Thank you for the investigation/PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the use of online httpbin with the local httpbin instance
provided via pytest-httpbin package. This makes the test suite offline,
effectively removing the need for pytest-network as well.