Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rhel-9.5: automatic: Use add_security_filters, not _update_security_filters #2091

Merged

Conversation

ppisar
Copy link
Contributor

@ppisar ppisar commented May 6, 2024

Upstream commit: 0b4b8cc
Resolves: https://issues.redhat.com/browse/RHEL-21874

@evan-goode, could you please review this rhel-9.5 backport of your commit?

Upstream commit: 0b4b8cc
Resolves: https://issues.redhat.com/browse/RHEL-21874

It seems that these two approaches for selecting security updates
sometimes disagree. The regular `dnf update` command uses
base.add_security_filters to select security updates, so dnf-automatic
should do the same.
Copy link
Member

@evan-goode evan-goode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I tested that dnf-automatic still applied a simple security update correctly on RHEL 9.4.

However, @bajertom and I have been unable to reproduce the original bug described in https://issues.redhat.com/browse/RHEL-21874. When I implemented this fix, I was able to reproduce the bug, and the fix worked, but something must have changed in the RHEL repositories that caused my reproducer to stop working.

We both have already spent a lot of time trying to find the root cause, so it may not be worth continuing to investigate. Regardless, this is a simple patch and the behavior of dnf and dnf-automatic with respect to security updates will now be unified.

@ppisar
Copy link
Contributor Author

ppisar commented May 9, 2024

Thanks for the review and the details.

@ppisar ppisar merged commit 5388d98 into rpm-software-management:rhel-9.5 May 9, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants