Skip to content

Commit

Permalink
podman: don't affect --shell stdout with podman image umout
Browse files Browse the repository at this point in the history
The `podman image umount` actually dumps the image ID to stdout.

Complements: b626045
Closes: #1218
  • Loading branch information
praiskup committed Sep 15, 2023
1 parent c15bd39 commit 92ccaee
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 1 addition & 1 deletion mock/py/mockbuild/podman.py
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ def mounted_image(self):
finally:
logger.info("umounting image %s (%s) with podman image umount",
self.image, mountpoint)
subprocess.run(cmd_umount, check=True)
subprocess.run(cmd_umount, capture_output=True, check=True)

@traceLog()
def cp(self, destination, tar_cmd):
Expand Down
2 changes: 2 additions & 0 deletions releng/release-notes-next/podman-image-unmount.bugfix
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
The `--shell` standard output is no longer affected by `podman image unmount`
output executed in the background (prints out the image ID).

0 comments on commit 92ccaee

Please sign in to comment.