PP-92: SDK Dapp review #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: mortelli <ortellimarcelo@gmail.com>
Co-authored-by: mortelli <ortellimarcelo@gmail.com>
Co-authored-by: mortelli <ortellimarcelo@gmail.com>
…ovlabs/relaying-services-sdk-dapp into fixes/review-readme-file
This reverts commit 0355232.
* Add package-lock.json Fix Readme Fix other mino issues * Remove "REACT_APP_RIF_RELAY_RELAY_LOOKUP_WINDOW_BLOCKS" from .env * Revert the change of the relaying-services-sdk package url in package.json
* Add initial dockerfile * Changes on Dockerfile
* Fix the shared status between the estimate and execute buttons. * Fix the return data slide button in the execute modal * Fix estimate loading on deploy modal * Add the estimation button and show the rbtc/trif switch
* Set the param on transfer
mortelli
reviewed
Feb 16, 2022
There was a problem hiding this comment.
thanks for tying up these loose ends. i've left some minor comments.
although all of our manual tests in the last month or 2 have been based on these changes, i still want to run this specific branch and make sure everything works/looks OK one last time before merging.
i'll do this as soon as my open threads are addressed and we can swiftly close this if no issues arise
Co-authored-by: mortelli <ortellimarcelo@gmail.com>
Co-authored-by: mortelli <ortellimarcelo@gmail.com>
Co-authored-by: mortelli <ortellimarcelo@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What