feature/PP-204 #25
Merged
feature/PP-204 #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antomor
requested changes
Aug 4, 2022
There was a problem hiding this comment.
@franciscotobar I like the new functionality, even if there are still some issues that need to be fixed.
franciscotobar
force-pushed
the
feature/PP-204
branch
from
8522292
to
06bc546
Compare
antomor
reviewed
Aug 12, 2022
antomor
reviewed
Aug 12, 2022
antomor
reviewed
Aug 12, 2022
antomor
requested changes
Aug 12, 2022
There was a problem hiding this comment.
@franciscotobar I found a small bug. If we try to click the reload button, we see the same SmartWallets multiple times in the UI.
antomor
reviewed
Aug 12, 2022
antomor
reviewed
Aug 12, 2022
antomor
reviewed
Aug 12, 2022
antomor
requested changes
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
Refs