Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: wait for transaction receipt on SW deployment #60

Merged
merged 3 commits into from
Mar 2, 2023
Merged

fix: wait for transaction receipt on SW deployment #60

merged 3 commits into from
Mar 2, 2023

Conversation

antomor
Copy link
Collaborator

@antomor antomor commented Mar 2, 2023

What

  • after requesting the server to relay a SW deployment, wait for the transaction receipt

Why

  • because right now the dapp shows a message that the SW failed, while the tx receipt isn't ready yet.

@antomor antomor self-assigned this Mar 2, 2023
@antomor antomor requested a review from a team March 2, 2023 11:01
@antomor antomor added the bug Something isn't working label Mar 2, 2023
ironFe93
ironFe93 approved these changes Mar 2, 2023
View reviewed changes
Copy link

@ironFe93 ironFe93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antomor antomor merged commit 4a9456a into main Mar 2, 2023
@antomor antomor deleted the PP-680/wait-for-sw-deployment branch March 2, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ironFe93 ironFe93 ironFe93 approved these changes

Assignees

@antomor antomor

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antomor @ironFe93