Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PP-729: add id/class to html elements to simplify test automation #61

Merged
merged 3 commits into from
Mar 8, 2023
Merged

PP-729: add id/class to html elements to simplify test automation #61

merged 3 commits into from
Mar 8, 2023

Conversation

antomor
Copy link
Collaborator

@antomor antomor commented Mar 7, 2023 •
edited
Loading

What

  • add id/class to html elements

Why

  • to simplify test automation

@antomor antomor changed the title Fix: add id/class to html elements add id/class to html elements Fix: add id/class to html elements to simplify test automation Mar 7, 2023
@antomor antomor marked this pull request as ready for review March 7, 2023 17:28
@antomor antomor self-assigned this Mar 7, 2023
@antomor antomor requested a review from a team March 7, 2023 17:28
@antomor
Copy link
Collaborator Author

antomor commented Mar 7, 2023

For the buttons, I've to use classes because the ID attribute isn't available in react-materialize, so the build was failing.

jd-iov
jd-iov approved these changes Mar 7, 2023
View reviewed changes
Copy link
Collaborator

@jd-iov jd-iov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me, thanks!

ironFe93
ironFe93 approved these changes Mar 7, 2023
View reviewed changes
Copy link

@ironFe93 ironFe93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@antomor antomor changed the title Fix: add id/class to html elements to simplify test automation PP-728: add id/class to html elements to simplify test automation Mar 8, 2023
@antomor antomor changed the title PP-728: add id/class to html elements to simplify test automation PP-729: add id/class to html elements to simplify test automation Mar 8, 2023
@antomor antomor merged commit 8bca74a into main Mar 8, 2023
@antomor antomor deleted the PP-729/add-id-to-html-elems branch March 8, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ironFe93 ironFe93 ironFe93 approved these changes

@jd-iov jd-iov jd-iov approved these changes

Assignees

@antomor antomor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antomor @ironFe93 @jd-iov