Update WebSocketHeadersSample #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First, the sample no longer needs to apply the ReassemblyDuplexConnection wrapper following d8da87. Another problem is that it was incorrectly trying to send a WebSocket status from an HTTP response code which was rejected by Reactor Netty. Arguably unauthorized upgrades should be rejected during the initial handshake, so now uses an HTTP request handler instead of a WebSocket handler disallows the upgrade if not authorized. Signed-off-by: Rossen Stoyanchev <rstoyanchev@pivotal.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sample no longer needs to apply the
ReassemblyDuplexConnectionwrapper following d8da87a. It was also incorrectly trying to send a WebSocket status based on an HTTP response code which caused an exception in Reactor Netty.Arguably unauthorized upgrades should be rejected earlier, during the initial handshake, so the sample is switched to use an HTTP request handler instead of a WebSocket handler in order to disallow the upgrade if not authorized.