Forward compatibility with Reactor Netty 1.0 #851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlegDokuka
approved these changes
May 29, 2020
rstoyanchev
force-pushed
the
reactor-netty-10
branch
from
b7029bd
to
e4466df
Compare
DisposableChannel#address was changed in reactor/reactor-netty#1081 to return SocketAddress instead of InetSocketAddress in order to support UNIX domain sockets. This is a binary incompatible change resulting in a new method in DisposableChannel in 1.0 vs 0.9.x. Signed-off-by: Rossen Stoyanchev <rstoyanchev@pivotal.io>
rstoyanchev
force-pushed
the
reactor-netty-10
branch
from
e4466df
to
de6d578
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DisposableChannel#addresswas changed in reactor/reactor-netty#1081 to returnSocketAddressinstead ofInetSocketAddressin order to support UNIX domain sockets. This is a binary incompatible change resulting in a new method inDisposableChannelin 1.0 and using RSocket compiled against 0.9.x causesNoSuchMethodError.