reworks multiplexer and improves tests to check async interceptors #909 #909
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reworks
ClientServerInputMultiplexer
to avoid async enqueueing/dequeuing of the incoming frames when interceptors offload subscription/publication on the differentScheduler
, so frame appears released at the time of its consumption (FluxReceiver
sendsByteBuf
and releases it onceonNext
is returned -> https://github.com/reactor/reactor-netty/blob/master/reactor-netty-core/src/main/java/reactor/netty/channel/FluxReceive.java#L264).Basically this PR gets rid of
groupBy
operator in favor of its drain-free version.FYI. This PR as well as changes related to refCoutning mechanics brake resumability.
It can wait since there is no usage of this feature in Spring-Messaging, though we should revise the whole resumability implementation before the final 1.1 release.
Signed-off-by: Oleh Dokuka shadowgun@i.ua