Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add months and years to Rails/DurationArithmetic cop duration method set #622

Merged
merged 1 commit into from
Jan 13, 2022

Conversation

agrobbin
Copy link
Contributor

month(s) and year(s) were inadvertently missed when implementation Rails/DurationArithmetic, so I've added them here! I've also add some additional test coverage to ensure we are accounting for all of these duration arithmetic methods.

@agrobbin agrobbin mentioned this pull request Jan 11, 2022
13 tasks
Copy link
Member

@pirj pirj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you!

CHANGELOG.md Outdated Show resolved Hide resolved
@agrobbin agrobbin force-pushed the duration-arithmetic-months-years branch from 21e9829 to d14ca7d Compare January 11, 2022 18:59
@agrobbin agrobbin force-pushed the duration-arithmetic-months-years branch from d14ca7d to 51afdbc Compare January 12, 2022 02:16
@agrobbin agrobbin force-pushed the duration-arithmetic-months-years branch from 51afdbc to cb61c72 Compare January 12, 2022 02:21
@koic koic merged commit 9bf85ea into rubocop:master Jan 13, 2022
@koic
Copy link
Member

koic commented Jan 13, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants