Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade rusqlite #647

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Upgrade rusqlite #647

wants to merge 1 commit into from

Conversation

gwenn
Copy link

@gwenn gwenn commented Apr 17, 2021

NO_PARAMS has been deprecated.
For homogeneous parameters, [value1, value2, ...] can be used
directly.
For heterogeneous parameters, params![value1, value2, ...] is
preferred.


Things to check before submitting a PR

  • the tests are passing locally with cargo test
  • cookbook renders correctly in mdbook serve -o
  • commits are squashed into one and rebased to latest master
  • spell check runs without errors ./ci/spellcheck.sh
  • link check runs without errors link-checker ./book
  • non rendered items are in sorted order (links, reference, identifiers, Cargo.toml)
  • links to docs.rs have wildcard version https://docs.rs/tar/*/tar/struct.Entry.html
  • example has standard error handling
  • code identifiers in description are in hyperlinked backticks
[`Entry::unpack`]: https://docs.rs/tar/*/tar/struct.Entry.html#method.unpack

Things to do after submitting PR

  • check if CI is happy with your PR

`NO_PARAMS` has been deprecated.
For homogeneous parameters, `[value1, value2, ...]` can be used
directly.
For heterogeneous parameters, `params![value1, value2, ...]` is
preferrred.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant