Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable dl_iterate_phdr for uclibc #396

Merged
merged 1 commit into from
Nov 24, 2020
Merged

Conversation

ykoehler
Copy link
Contributor

No description provided.

@alexcrichton
Copy link
Member

Thanks for this! Is this perhaps indicative of missing bindings in the libc crate though? Presumably uclibc has support for these functions?

@ykoehler
Copy link
Contributor Author

ykoehler commented Nov 24, 2020 via email

@alexcrichton
Copy link
Member

Ok! In that case this seems fine for now and it can always be updated later if necessary.

@alexcrichton alexcrichton merged commit 47069af into rust-lang:master Nov 24, 2020
@tsidea
Copy link

tsidea commented Nov 26, 2020

Just fyi. The dl_iterate_phdr is present in the latest uclibc release here and added in this commit. As such, I've managed to create a pull request for libc to include dl_iterate_phdr for uclibc here. I'm not sure if that changes anything with respect to this pull request, I just thought it might be relevant.

@ykoehler
Copy link
Contributor Author

ok, that implies I will need to upgrade our uClibc version in our toolchain/env, nightmares ahead... but I understand. Thanks

@tsidea
Copy link

tsidea commented Nov 29, 2020

If just having the dl_iterate_phdr binding present in libc will not affect your code, then maybe you don't need to change. If backtrace-rs can work without dl_iterate_phdr, then you're probably all set and don't need to make any more changes. You can check whether this is true by building your rust compiler with the latest libc. Try using the latest libc by adding this patch libc = { git = 'https://github.com/rust-lang/libc.git' } in your rust compiler's working directory Cargo.toml, in the section [patch.crates-io]. Build the rust compiler and test your project in your environment and see what happens. If all is well then you don't need to upgrade just yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants