Rust 1.20.0 release post #192

steveklabnik · 2017-08-29T18:41:36Z

r? @rust-lang/core

I modified our slogan slightly to see how it feels; we can change it back if it's not great.

CryZe · 2017-08-29T18:45:21Z

_posts/2017-08-31-Rust-1.20.md

+}
+```
+
+These are called "associated functions" becuase they are functions that are


CryZe · 2017-08-29T18:45:53Z

_posts/2017-08-31-Rust-1.20.md

+Back in [Rust 1.14], we announced preliminary support for asm.js and wasm
+with the help of Emscripten. Since then, LLVM has added its own support, and
+so, we have [added native wasm support to Rust]! It's using the
+`wasm32-experimental-emscripten` target.


I think that's just what we decided to call it, not what the LLVM target is actually called.

Yes, that was my intention. Any idea of how to word it better?

This new target is named wasm32-experimental-emscripten.

When mentioning this I think we'd just want to set expectations by saying that it's an experimental target and doesn't even have nightly support right now. Furthermore this isn't even using our LLVM's backend support for WebAssembly but rather we still ship IR to emscripten (AFAIK) and then emscripten uses LLVM's WebAssembly backend.

All in all this may not be worth calling out :(

CryZe · 2017-08-29T18:47:55Z

_posts/2017-08-31-Rust-1.20.md

+#### Library stabilizations
+
+There's nothing *super* exciting in libraries this release, just a number of solid
+improvements and continued stabilizing of APIs.


I think this section should mention unstable sort, which is often faster than stable sort and actually works with just libcore too, unlike slice::sort.

That wasn't in the release notes, can you link me to a PR?

It is in the release notes:

The following APIs were also stabilized:
...

slice::sort_unstable_by_key, slice::sort_unstable_by, and slice::sort_unstable

ah sorry, i see now. yeah, sounds good!

nrc · 2017-08-29T19:56:33Z

We should mention this minor breaking change- rust-lang/rust#43782 (also backported to beta, so it will be in 1.20 stable):

Doc test bug fix: when using include! and include_str! in documentation examples, the semantics of the path has changed for doc tests. The path is now relative to the current file (like using include! in regular code), it used to be relative to the directory outside the crate root.

carols10cents · 2017-08-29T22:20:38Z

_posts/2017-08-31-Rust-1.20.md

+Cargo has some nice upgrades this release. First of all, your crates.io
+authentication token used to be stored in `~/.cargo/config`. As a configuration
+file, this would often be stored with `644` permissions, that is, world-readable.
+But it has a secret token in it. We've [moved the token] `~/.cargo/credentials`,


I think this should say "We've [moved the token] to ~/.cargo/credentials"... it's not quite the pittsburghese dropping of "to be" that i might let you get away with ;)

carols10cents · 2017-08-29T22:28:21Z

_posts/2017-08-31-Rust-1.20.md

+file, this would often be stored with `644` permissions, that is, world-readable.
+But it has a secret token in it. We've [moved the token] `~/.cargo/credentials`,
+so that it can be permissioned `600`, and hidden from other users on your system.
+You'll get a warning if it's still in your `~/.cargo/config`.


This is not true, I just tried with rustc 1.21.0-beta.1/cargo 0.22.0-beta-- I had a token in both credentials and config and it used the ones in credentials but didn't print any warnings. There was some talk of warnings, but decided to not add them until this was stable, and I don't think that was ever implemented...?

oops; I must have read the wrong summary comment :(

Yeah once we make this stable release we'll start issuing warnings

Mark-Simulacrum · 2017-08-29T22:59:14Z

_posts/2017-08-31-Rust-1.20.md

+
+### What's in 1.20.0 stable
+
+In Rust, you can define traits, structs, and enums that have "associated functions":


Maybe "you can already define"? That way it's clear this isn't a new feature.

Oh yeah, that confused me as well.

alexcrichton · 2017-08-30T00:00:54Z

_posts/2017-08-31-Rust-1.20.md

+We now [skip the main thread's manual stack guard on
+Linux](https://github.com/rust-lang/rust/pull/43072), due to mitigations in
+the kernel against [Stack
+Clash](https://access.redhat.com/security/vulnerabilities/stackguard).


Perhaps more importantly than this we may want to mention the support for stack probes here, basically saying that you're guaranteed a segfault on stack overflow on x86/x86_64, rather than having the possibility of jumping over the guard page. (again still motivated by the stack clash stuff)

i wasn't sure if that was in this release or not since it didn't make the notes

aturon · 2017-08-30T03:50:59Z

LGTM modulo nits already posted.

petrochenkov · 2017-08-30T08:35:36Z

_posts/2017-08-31-Rust-1.20.md

+}
+```
+
+much cleaner, and more versitile.


Typo: versatile

steveklabnik · 2017-08-30T21:27:38Z

I believe I have addressed all review comments; please check it out before we tomorrow!

Rust 1.20.0 release post

eba7d7c

CryZe reviewed Aug 29, 2017

View reviewed changes

carols10cents requested changes Aug 29, 2017

View reviewed changes

Mark-Simulacrum reviewed Aug 29, 2017

View reviewed changes

alexcrichton reviewed Aug 30, 2017

View reviewed changes

petrochenkov reviewed Aug 30, 2017

View reviewed changes

_posts/2017-08-31-Rust-1.20.md Outdated

}

```

much cleaner, and more versitile.

Copy link

Contributor

petrochenkov Aug 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: versatile

address review comments

f2d1aba

steveklabnik force-pushed the 1.20-announcement branch from 73b5bf4 to f2d1aba Compare August 30, 2017 21:28

steveklabnik merged commit d42e013 into gh-pages Aug 31, 2017

steveklabnik deleted the 1.20-announcement branch August 31, 2017 17:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rust 1.20.0 release post #192

Rust 1.20.0 release post #192

steveklabnik commented Aug 29, 2017

CryZe Aug 29, 2017

CryZe Aug 29, 2017

steveklabnik Aug 29, 2017

CryZe Aug 29, 2017

alexcrichton Aug 29, 2017

CryZe Aug 29, 2017 •

edited

Loading

steveklabnik Aug 29, 2017

CryZe Aug 29, 2017 •

edited

Loading

steveklabnik Aug 29, 2017

nrc commented Aug 29, 2017

carols10cents Aug 29, 2017

carols10cents Aug 29, 2017

steveklabnik Aug 29, 2017

alexcrichton Aug 30, 2017

Mark-Simulacrum Aug 29, 2017

CryZe Aug 29, 2017

alexcrichton Aug 30, 2017

steveklabnik Aug 30, 2017

aturon commented Aug 30, 2017

petrochenkov Aug 30, 2017

steveklabnik commented Aug 30, 2017


		### What's in 1.20.0 stable

		In Rust, you can define traits, structs, and enums that have "associated functions":

Rust 1.20.0 release post #192

Rust 1.20.0 release post #192

Conversation

steveklabnik commented Aug 29, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

CryZe Aug 29, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

CryZe Aug 29, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nrc commented Aug 29, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aturon commented Aug 30, 2017

Choose a reason for hiding this comment

steveklabnik commented Aug 30, 2017

CryZe Aug 29, 2017 •

edited

Loading

CryZe Aug 29, 2017 •

edited

Loading