Skip to content

Commit

Permalink
Auto merge of #12842 - weihanglo:remove-notice, r=epage
Browse files Browse the repository at this point in the history
docs: remove review capacity notice

The Cargo project is in a better state than it was when maintainers added this notice. I believe it's time to take it down, as maintainers have got more time on it, and more people are willing to contribute to the project constantly.

Note that this doesn't mean Cargo start accepting arbitrary pull requests or features. The reviewers are still a small handful of people. The guideline never change — issue, discuss, then pull request.
  • Loading branch information
bors committed Oct 18, 2023
2 parents 1416678 + 6f3e30b commit 9b99415
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 13 deletions.
10 changes: 4 additions & 6 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,12 @@ Contributing documentation has moved to the **[Cargo Contributor Guide]**.

We encourage people to discuss their design before hacking on code. Typically,
you [file an issue] or start a thread on the [internals forum] before submitting
a pull request. Please read [the process] of how features and bugs are managed
in Cargo.
a pull request.

**NOTICE: Due to limited review capacity, the Cargo team is not accepting new
features or major changes at this time. Please consult with the team before
opening a new PR. Only issues that have been explicitly marked as accepted
will be reviewed.**
Please read [the process] of how features and bugs are managed in Cargo.
**Only issues that have been explicitly marked as [accepted] will be reviewed.**

[internals forum]: https://internals.rust-lang.org/c/tools-and-infrastructure/cargo
[file an issue]: https://github.com/rust-lang/cargo/issues
[the process]: https://doc.crates.io/contrib/process/index.html
[accepted]: https://github.com/rust-lang/cargo/issues?q=is%3Aissue+is%3Aopen+label%3AS-accepted
5 changes: 0 additions & 5 deletions src/doc/contrib/src/process/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,6 @@ process.

Please read the guidelines below before working on an issue or new feature.

**Due to limited review capacity, the Cargo team is not accepting new features
or major changes at this time. Please consult with the team before opening a
new PR. Only issues that have been explicitly marked as accepted will be
reviewed.**

[Working on Cargo]: working-on-cargo.md

## Mentorship
Expand Down
7 changes: 5 additions & 2 deletions src/doc/contrib/src/process/working-on-cargo.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,10 @@ We encourage people to discuss their design before hacking on code. This gives
the Cargo team a chance to know your idea more. Sometimes after a discussion,
we even find a way to solve the problem without coding! Typically, you
[file an issue] or start a thread on the [internals forum] before submitting a
pull request. Please read [the process] of how features and bugs are managed in
Cargo.
pull request.

Please read [the process] of how features and bugs are managed in Cargo.
**Only issues that have been explicitly marked as [accepted] will be reviewed.**

## Checkout the source

Expand Down Expand Up @@ -170,3 +172,4 @@ more information on how Cargo releases are made.
[internals forum]: https://internals.rust-lang.org/c/tools-and-infrastructure/cargo
[file an issue]: https://github.com/rust-lang/cargo/issues
[the process]: index.md
[accepted]: https://github.com/rust-lang/cargo/issues?q=is%3Aissue+is%3Aopen+label%3AS-accepted

0 comments on commit 9b99415

Please sign in to comment.