Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the use of alternative registry names in [patch] #5149

Closed
sfackler opened this issue Mar 8, 2018 · 3 comments · Fixed by #6456
Closed

Allow the use of alternative registry names in [patch] #5149

sfackler opened this issue Mar 8, 2018 · 3 comments · Fixed by #6456
Labels
A-registries Area: registries

Comments

@sfackler
Copy link
Member

sfackler commented Mar 8, 2018

If you have an alternative registry configured and want to patch a crate in it, you currently have to spell out the entire URL:

.cargo/config

[registries.foobar]
index = "https://foobar.com/some-long-url/index"

Cargo.toml

...

[dependencies]
thingy = { version = "0.1", registry = "foobar" }

[patch."https://foobar.com/some-long-url/index"]
thingy = { git = "https://somewhere-else.com" }

But it's a bit annoying to have to write the whole URL around (and is the only place you're allowed to use the alternative registry URL directly in Cargo.toml). It'd be great if this worked instead:

[patch.foobar]
thingy = { git = "https://somewhere-else.com" }
@sfackler sfackler changed the title Allow the use of registry names in [patch] Allow the use of alternative registry names in [patch] Mar 8, 2018
@alexcrichton alexcrichton added the A-registries Area: registries label Mar 8, 2018
@stale
Copy link

stale bot commented Sep 16, 2018

As there hasn't been any activity here in over 6 months I've marked this as stale and if no further activity happens for 7 days I will close it.

I'm a bot so this may be in error! If this issue should remain open, could someone (the author, a team member, or any interested party) please comment to that effect?

The team would be especially grateful if such a comment included details such as:

  • Is this still relevant?
  • If so, what is blocking it?
  • Is it known what could be done to help move this forward?

Thank you for contributing!

If you're reading this comment from the distant future, fear not if this was closed automatically. If you believe it's still an issue please leave a comment and a team member can reopen this issue. Opening a new issue is also acceptable!

@stale stale bot added the stale label Sep 16, 2018
@sfackler
Copy link
Member Author

This is still a nice to have - someone just needs to put in the work to implement it.

@stale stale bot removed the stale label Sep 16, 2018
@dwijnand
Copy link
Member

On face value this looks like it's just a simple lookup. If someone were to leave me some mentoring instructions I'd be happy to have take a swing at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-registries Area: registries
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants