Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test if reserved filenames are allowed in Windows #10322

Merged
merged 5 commits into from
Aug 4, 2022
Merged

Test if reserved filenames are allowed in Windows #10322

merged 5 commits into from
Aug 4, 2022

Commits on Aug 3, 2022

  1. Test if reserved filenames are allowed in Windows 

    Recent versions of Windows have removed the limitation on filenames like
`aux` or `con`. This change allows the `package::reserved_windows_name`
to still pass by first trying to create a file with a reserved name to
see if Windows supports it. If so, it skips the rest of the test.
Otherwise, we keep the same behavior as before.
    @eholk
    eholk committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    0adcc18 View commit details
    Browse the repository at this point in the history

  2. Use GetFullPathNameW to test restricted names 

    The previous commit tests whether the current machine supports Windows
restricted names by creating a file and checking whether that succeeds.
This commit reworks this testto use GetFullPathNameW, which can be done
without having to create and remove new files.
    @eholk
    eholk committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    f122dbb View commit details
    Browse the repository at this point in the history

  3. Update comment

    @eholk
    eholk committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    d03530f View commit details
    Browse the repository at this point in the history

  4. Move Windows path test function to test code

    @eholk
    eholk committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    e9c7544 View commit details
    Browse the repository at this point in the history

  5. Use old Windows path handling on CI

    @eholk
    eholk committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    8de9adf View commit details
    Browse the repository at this point in the history