Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle case mismatches when looking up env vars in the Config snapshot #11824

Merged
merged 7 commits into from
Mar 17, 2023
Merged

Handle case mismatches when looking up env vars in the Config snapshot #11824

merged 7 commits into from
Mar 17, 2023

Commits on Mar 9, 2023

  1. add unit test for config and integration test with cargo --list

    @kylematsuda
    kylematsuda committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    8353396 View commit details
    Browse the repository at this point in the history

  2. store uppercased env var names; look for uppercased version on Window… 

    …s when var is not in self.env
    @kylematsuda
    kylematsuda committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    0255c30 View commit details
    Browse the repository at this point in the history

  3. change set_env to update case_insensitive_env and normalized_env (nee… 

    …ded for tests)
    @kylematsuda
    kylematsuda committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    3c8633a View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2023

  1. use String instead of OsString in case_insensitive_env so we can use … 

    …unicode uppercase instead of ascii
    @kylematsuda
    kylematsuda committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    8ae0773 View commit details
    Browse the repository at this point in the history

  2. add free function to generate auxiliary envs

    @kylematsuda
    kylematsuda committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    35b53b8 View commit details
    Browse the repository at this point in the history

  3. factor out three hashmaps in Config into a new struct for better enca… 

    …psulation
    @kylematsuda
    kylematsuda committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    f810234 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2023

  1. improve docstrings for config::environment

    @kylematsuda
    kylematsuda committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    7af55d8 View commit details
    Browse the repository at this point in the history