Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Allow embedded manifests in all commands #12289

Merged
merged 8 commits into from
Jun 21, 2023
Merged

fix: Allow embedded manifests in all commands #12289

merged 8 commits into from
Jun 21, 2023

Commits on Jun 19, 2023

  1. test(embedded): Verify existing behavior on basic commands

    @epage
    epage committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    98ed8ab View commit details
    Browse the repository at this point in the history

  2. docs(embedded): Cross-link impls

    @epage
    epage committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    2cd89e3 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2023

  1. fix: Allow embedded manifests in all commands 

    I originally centralized the error reporting until I realized it likely
is intentionally not centralized so we report errors in terms of the
arguments the user provided.
    @epage
    epage committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    4e49af4 View commit details
    Browse the repository at this point in the history

  2. fix(cli): Unify manifest path error handling

    @epage
    epage committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    7b5fe7b View commit details
    Browse the repository at this point in the history

  3. fix(cli): Ensure we don't accidentally let embedded manifests on stable 

    There should be a later check when parsing but just in case, let's have
a check here as well.
    @epage
    epage committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    b139489 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2023

  1. test(cli): Verify directory-manifest behaivor

    @epage
    epage committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    af69746 View commit details
    Browse the repository at this point in the history

  2. test(cli): Verify missing-manifest behavior

    @epage
    epage committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    85023c4 View commit details
    Browse the repository at this point in the history

  3. fix(cli): Improve error on manifest dir

    @epage
    epage committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    d8583f4 View commit details
    Browse the repository at this point in the history