Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Consistently compare MSRVs #13537

Merged
merged 4 commits into from
Mar 8, 2024
Merged

fix: Consistently compare MSRVs #13537

merged 4 commits into from
Mar 8, 2024

Commits on Mar 4, 2024

  1. refactor(schema): Make manifest its own directory

    @epage
    epage committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    a980eed View commit details
    Browse the repository at this point in the history

  2. refactor(schema): Pull RustVersion out into a mod

    @epage
    epage committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    46584a4 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2024

  1. refactor: Clarify some variable names

    @epage
    epage committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    1616881 View commit details
    Browse the repository at this point in the history

  2. fix: Consistently compare MSRVs 

    We used several strategies
- Relying in `impl Ord for RustVersion`
- Converting to version requirements
  - Decrementing a version

This consolidates around one strategy: `RustVersion::is_compatible_with`
- Ensure the comparisons have the same behavior
- Centralize knowledge of how to handle pre-release rustc
- Losslessly allow comparing with either rustc or workspace msrv
    @epage
    epage committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    134ed93 View commit details
    Browse the repository at this point in the history