Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(toml): Flatten manifest parsing #13589

Merged
merged 19 commits into from
Mar 15, 2024
Merged

refactor(toml): Flatten manifest parsing #13589

merged 19 commits into from
Mar 15, 2024

Commits on Mar 15, 2024

  1. refactor: Group alt Manifest formats 

    This is prep for adding more
    @epage
    epage committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    c8fa709 View commit details
    Browse the repository at this point in the history

  2. refactor: Clarify what Manifest::original means 

    I plan to add a true `original`
    @epage
    epage committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    89f1cce View commit details
    Browse the repository at this point in the history

  3. refactor(toml): Pull fs out as explicit step 

    So diagnostics can use this for reporting.
    @epage
    epage committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    69ee34a View commit details
    Browse the repository at this point in the history

  4. refactor(toml): Pull out diagnostic emitting

    @epage
    epage committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    490583a View commit details
    Browse the repository at this point in the history

  5. refactor(toml): Pull out deserialize code 

    - So we can eventually track the `original`
- So we can track spans for diagnostics
    @epage
    epage committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    66b19ad View commit details
    Browse the repository at this point in the history

  6. refactor(toml): Resolve toml_edit deprecations

    @epage
    epage committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    c272cd7 View commit details
    Browse the repository at this point in the history

  7. refactor(toml): Pull out toml parsing 

    So we can track spans for diagnostics
    @epage
    epage committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    b174346 View commit details
    Browse the repository at this point in the history

  8. refactor(toml): Move steps to top-level 

    Before, we split things up.  This makes it so everything has access to
every step so we can reap the benefits
- use `&str` and `ImDocument` for diagnostics
- access `original`
    @epage
    epage committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    069c67a View commit details
    Browse the repository at this point in the history

  9. refactor(toml): Simplify virtual manifest check

    @epage
    epage committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    8cd94e4 View commit details
    Browse the repository at this point in the history

  10. refactor(toml): Pull out unused warning code

    @epage
    epage committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    a7b70e9 View commit details
    Browse the repository at this point in the history

  11. refactor(toml): Consolidate no-target errors 

    Moving this out for collapsing `convert_toml`
    @epage
    epage committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    401c502 View commit details
    Browse the repository at this point in the history

  12. fix(toml): Remove redundant trace

    @epage
    epage committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    65bf96a View commit details
    Browse the repository at this point in the history

  13. refactor(toml): Centralize error wrapping

    @epage
    epage committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    fcc6981 View commit details
    Browse the repository at this point in the history

  14. fix(toml): Produce warnings for virtual manifests 

    This is prep for shifting unused keys warnings out of `convert_toml`
    @epage
    epage committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    7143592 View commit details
    Browse the repository at this point in the history

  15. refactor(toml): Consolidate how we track unused keys 

    This makes it act more like everything else, making this easier to
evolve over time.
    @epage
    epage committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    ff454fd View commit details
    Browse the repository at this point in the history

  16. refactor(toml): Move path processing out of convert_toml 

    This is in an effort to remove `convert_toml`
    @epage
    epage committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    37c3080 View commit details
    Browse the repository at this point in the history

  17. refactor(toml): Move path workspace dep validation out of convert_toml 

    This is part of an effort to remove `convert_toml`
    @epage
    epage committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    954142e View commit details
    Browse the repository at this point in the history

  18. refactor(toml): Only collect nested paths when needed 

    This simplifies the interface for `toml/mod.rs` and reduces the work we
do.
    @epage
    epage committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    dd56d79 View commit details
    Browse the repository at this point in the history

  19. refactor(toml): Flatten convert_toml 

    This is to work towards tracking everything needed for diagnostics in
`Manifest`
    @epage
    epage committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    4ed67e3 View commit details
    Browse the repository at this point in the history