Correctly attempt multiple usernames with libgit2 #2584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors r+ |
|
📌 Commit d81776b has been approved by |
|
⌛ Testing commit d81776b with merge 8d21210... |
|
💔 Test failed - cargo-mac-64 |
|
@bors: r=brson 897034e |
|
⌛ Testing commit 897034e with merge c8af5df... |
|
💔 Test failed - cargo-win-msvc-64 |
This commit corrects the logic for attempting multiple usernames with libgit2. There is a restriction that for each authentication seession you can only authenticate with one ssh username, but we were attempting multiple as part of the same sesssion. Instead restart authentication whenever we try a new username. Closes rust-lang#2399
|
@bors: r=brson |
|
📌 Commit 537f718 has been approved by |
bors
added a commit
that referenced
this pull request
Apr 18, 2016
Correctly attempt multiple usernames with libgit2 This commit corrects the logic for attempting multiple usernames with libgit2. There is a restriction that for each authentication seession you can only authenticate with one ssh username, but we were attempting multiple as part of the same sesssion. Instead restart authentication whenever we try a new username. Closes #2399
|
☀️ Test successful - cargo-cross-linux, cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32, cargo-win-msvc-64 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit corrects the logic for attempting multiple usernames with libgit2.
There is a restriction that for each authentication seession you can only
authenticate with one ssh username, but we were attempting multiple as part of
the same sesssion. Instead restart authentication whenever we try a new username.
Closes #2399