Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Untar into the right dir when verifying #4851

Merged
merged 1 commit into from
Dec 22, 2017

Conversation

sfackler
Copy link
Member

We'd previously dump it in the package's directory which is wrong when
working in a workspace.

Closes #4304

r? @alexcrichton

We'd previously dump it in the package's directory which is wrong when
working in a workspace.

Closes rust-lang#4304
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Collaborator

bors commented Dec 21, 2017

📌 Commit c4565a6 has been approved by alexcrichton

@bors
Copy link
Collaborator

bors commented Dec 21, 2017

⌛ Testing commit c4565a6 with merge 848eb15...

bors added a commit that referenced this pull request Dec 21, 2017
Untar into the right dir when verifying

We'd previously dump it in the package's directory which is wrong when
working in a workspace.

Closes #4304

r? @alexcrichton
@bors
Copy link
Collaborator

bors commented Dec 22, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 848eb15 to master...

@bors bors merged commit c4565a6 into rust-lang:master Dec 22, 2017
@sfackler sfackler deleted the verify-in-target branch December 23, 2017 04:17
@ehuss ehuss added this to the 1.24.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cargo package in workspaces doesn't put artifacts in root target dir
4 participants