Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure tar to not set mtime #6257

Merged
merged 2 commits into from
Nov 5, 2018
Merged

Configure tar to not set mtime #6257

merged 2 commits into from
Nov 5, 2018

Conversation

khionu
Copy link
Member

@khionu khionu commented Nov 3, 2018

This PR is fixes #6238. Currently uses a patch on tar, and should not be merged until tar makes a release containing the function set_preserve_mtime.

Signed-off-by: Khionu Sybiern <dev@khionu.net>
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@ehuss
Copy link
Contributor

ehuss commented Nov 3, 2018

Noted on Discord, the minimal-versions jobs failed because the tar version needs to be bumped to 0.4.17 to pick up the version from git. Presumably once a new tar is published and the version is bumped in Cargo.toml, it should pass.

@alexcrichton
Copy link
Member

Ok I've pushed 0.4.18 for tar! I think if that's updated here this should be good to go

Signed-off-by: Khionu Sybiern <dev@khionu.net>
@alexcrichton alexcrichton changed the title WIP - Configure tar to not set mtime Configure tar to not set mtime Nov 5, 2018
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Collaborator

bors commented Nov 5, 2018

📌 Commit 5a59494 has been approved by alexcrichton

@bors
Copy link
Collaborator

bors commented Nov 5, 2018

⌛ Testing commit 5a59494 with merge b5462e609f53efd093f2d297d5680efcc79be5a1...

@bors
Copy link
Collaborator

bors commented Nov 5, 2018

💔 Test failed - status-travis

@Eh2406
Copy link
Contributor

Eh2406 commented Nov 5, 2018

flakey test
@bors: retry

@bors
Copy link
Collaborator

bors commented Nov 5, 2018

⌛ Testing commit 5a59494 with merge 6411d39...

bors added a commit that referenced this pull request Nov 5, 2018
Configure tar to not set mtime

This PR is fixes #6238. Currently uses a `patch` on `tar`, and should not be merged until `tar` makes a release containing the function `set_preserve_mtime`.
@bors
Copy link
Collaborator

bors commented Nov 5, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 6411d39 to master...

@bors bors merged commit 5a59494 into rust-lang:master Nov 5, 2018
@ehuss ehuss added this to the 1.32.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failure to package on FAT-family filesystems
6 participants