Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable progress bar on CI. #6281

Merged
merged 1 commit into from
Nov 8, 2018
Merged

Disable progress bar on CI. #6281

merged 1 commit into from
Nov 8, 2018

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Nov 7, 2018

Due to the recent change (#6233) to use ansi escape codes to clear the progress bar, Travis logs are looking quite odd. Generally you don't want the progress bar during CI builds anyways, so just disable it if "CI" is set, which most of the CI services do.

@rust-highfive
Copy link

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

r=me, but can a comment be added as well as to why the clause is there?

@ehuss
Copy link
Contributor Author

ehuss commented Nov 7, 2018

Oops, yea!

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Collaborator

bors commented Nov 7, 2018

📌 Commit f06a9e9 has been approved by alexcrichton

@bors
Copy link
Collaborator

bors commented Nov 7, 2018

⌛ Testing commit f06a9e9 with merge 2607b6af6593405c9e860e14ca880f93623db943...

@bors
Copy link
Collaborator

bors commented Nov 8, 2018

💥 Test timed out

@dwijnand
Copy link
Member

dwijnand commented Nov 8, 2018

@bors: retry

@bors
Copy link
Collaborator

bors commented Nov 8, 2018

⌛ Testing commit f06a9e9 with merge 1ffd248...

bors added a commit that referenced this pull request Nov 8, 2018
Disable progress bar on CI.

Due to the recent change (#6233) to use ansi escape codes to clear the progress bar, Travis logs are looking quite odd. Generally you don't want the progress bar during CI builds anyways, so just disable it if "CI" is set, which most of the CI services do.
@bors
Copy link
Collaborator

bors commented Nov 8, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 1ffd248 to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants