Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when excluding non-existing packages #6679

Merged
merged 2 commits into from
Feb 20, 2019

Conversation

dwijnand
Copy link
Member

Fixes #6678

src/cargo/ops/cargo_compile.rs Outdated Show resolved Hide resolved
src/cargo/ops/cargo_compile.rs Outdated Show resolved Hide resolved
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Collaborator

bors commented Feb 20, 2019

📌 Commit 45ce445 has been approved by alexcrichton

@bors
Copy link
Collaborator

bors commented Feb 20, 2019

⌛ Testing commit 45ce445 with merge 710c1a21cac57eb0fde183a6442049d8d0c1cf60...

@bors
Copy link
Collaborator

bors commented Feb 20, 2019

💔 Test failed - checks-travis

@dwijnand
Copy link
Member Author

@bors retry

@bors
Copy link
Collaborator

bors commented Feb 20, 2019

⌛ Testing commit 45ce445 with merge fdb1426...

bors added a commit that referenced this pull request Feb 20, 2019
Warn when excluding non-existing packages

Fixes #6678
@bors
Copy link
Collaborator

bors commented Feb 20, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: alexcrichton
Pushing fdb1426 to master...

@bors bors merged commit 45ce445 into rust-lang:master Feb 20, 2019
@dwijnand dwijnand deleted the exclude-mia-package branch February 20, 2019 21:44
bors added a commit to rust-lang/rust that referenced this pull request Feb 23, 2019
Update cargo

5 commits in b33ce7fc9092962b0657b4c25354984b5e5c47e4..5c6aa46e6f28661270979696e7b4c2f0dff8628f
2019-02-19 18:42:50 +0000 to 2019-02-22 19:32:35 +0000
- convert unused doc comments to regular comments (rust-lang/cargo#6692)
- Add more about system library on whether to keep Cargo.lock (rust-lang/cargo#6685)
- Warn when excluding non-existing packages (rust-lang/cargo#6679)
- Incremental profile cleanup. (rust-lang/cargo#6688)
- Various cosmetic improvements (rust-lang/cargo#6687)
@ehuss ehuss added this to the 1.34.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--exclude doesn't warn when excluding non-existing packages
4 participants