Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work with canonical URLs in [patch] #7368

Merged
merged 1 commit into from
Sep 17, 2019

Commits on Sep 17, 2019

  1. Work with canonical URLs in [patch]

    This commit addresses an issue with how the resolver processes `[patch]`
    annotations in manifests and lock files. Previously the resolver would
    use the raw `Url` coming out of a manifest, but the rest of resolution,
    when comparing `SourceId`, uses a canonical form of a `Url` rather than
    the actual raw `Url`. This ended up causing discrepancies like those
    found in rust-lang#7282.
    
    To fix the issue all `patch` intermediate storage in the resolver uses a
    newly-added `CanonicalUrl` type instead of a `Url`. This
    `CanonicalUrl` is then also used throughout the codebase, and all
    lookups in the resolver as switched to using `CanonicalUrl` instead of
    `Url`, which...
    
    Closes rust-lang#7282
    alexcrichton committed Sep 17, 2019
    Configuration menu
    Copy the full SHA
    e545412 View commit details
    Browse the repository at this point in the history