Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an accidental raw access of field #8319

Merged
merged 1 commit into from
Jun 3, 2020

Commits on Jun 3, 2020

  1. Fix an accidental raw access of field

    The manifest has a few different ways of specifying whether a crate is a
    procedural macro, and there's a `TomlTarget::proc_macro()` method to
    unify these various lines. Unfortunately though we had a bug where one
    location forgot to call the method and read the raw field! This led to
    surprising behavior where the different ways to specify a proc macro
    would have subtly different changes in behavior. The fix here in this PR
    is to ensure that we access the property always via the method.
    
    Closes rust-lang#8315
    alexcrichton committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    442f629 View commit details
    Browse the repository at this point in the history