Add spaces after -C and -Z flags for consistency #8648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most other options have a space after flag name. This commit makes verbose output of rustc invocations a little bit cleaner.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ehuss (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
Thanks! |
|
📌 Commit 8164c1d has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
ehuss
pushed a commit
to ehuss/cargo
that referenced
this pull request
Aug 28, 2020
Add spaces after -C and -Z flags for consistency Most other options have a space after flag name. This commit makes verbose output of rustc invocations a little bit cleaner.
bors
added a commit
that referenced
this pull request
Aug 28, 2020
[beta] Fix LTO with doctests. Beta packports: * #8653 Fix cache_messages::rustdoc test broken on beta. — so that CI tests pass * #8648 Add spaces after -C and -Z flags for consistency — so that #8657 can be merged * #8657 Fix LTO with doctests. Although the LTO regression is on 1.46, I probably won't do a stable backport even if there is a point release, as I think it would be good to have sufficient time for testing on nightly, and I don't want to rush it. I'm willing to reconsider that, though.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 31, 2020
Update cargo 8 commits in 51b66125ba97d2906f461b3f4e0408f206299bb6..126907a7cfccbe93778530e6a6bbaa3adb6c515c 2020-08-19 20:22:52 +0000 to 2020-08-31 20:42:11 +0000 - Fix flakiness in close_output test (rust-lang/cargo#8668) - Reload unstable table from config file in `reload_rooted_at` (rust-lang/cargo#8656) - Bump to 0.49.0, update changelog (rust-lang/cargo#8659) - Fix LTO with doctests. (rust-lang/cargo#8657) - Add spaces after -C and -Z flags for consistency (rust-lang/cargo#8648) - Fix cache_messages::rustdoc test broken on beta. (rust-lang/cargo#8653) - fix: remove unnecessary allocations (rust-lang/cargo#8641) - Fixed a spelling and some clippy warnings (rust-lang/cargo#8637)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most other options have a space after flag name.
This commit makes verbose output of rustc invocations a little bit cleaner.