Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add [env] section to reference #9297

Closed
wants to merge 1 commit into from
Closed

Add [env] section to reference #9297

wants to merge 1 commit into from

Conversation

flxo
Copy link

@flxo flxo commented Mar 24, 2021

With #9175 the [env] section is added to the configuration which allows to set environment variables from the cargo configuration. Add the [env] section with an example to the reference.

Fixes #9296

With #9175 the [env] section is added to the configuration which
allows to set environment variables from the cargo configuration.
Add the [env] section with an example to the reference.

Fixes #9296
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 24, 2021
@flxo
Copy link
Author

flxo commented Mar 24, 2021

The CI failed because of network failures. Can someone retrigger?

@ehuss
Copy link
Contributor

ehuss commented Mar 24, 2021

Thanks for the PR! The [env] documentation may be found here: https://doc.rust-lang.org/nightly/cargo/reference/unstable.html#configurable-env

Unstable documentation is always in the unstable chapter, and will be moved out when it is stabilized.

@flxo
Copy link
Author

flxo commented Mar 24, 2021

Thanks for the PR! The [env] documentation may be found here: https://doc.rust-lang.org/nightly/cargo/reference/unstable.html#configurable-env

Unstable documentation is always in the unstable chapter, and will be moved out when it is stabilized.

Ah ok. Thanks - I missed that and didn't notice when reading the contribution guides. My thought was that since the doc patch is not in the original PR with the feature that it's missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing documentation about [env] section
4 participants