-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancements to testsuite error output. #9589
Merged
Merged
Commits on Jun 15, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 2021865 - Browse repository at this point
Copy the full SHA 2021865View commit details
Commits on Jun 16, 2021
-
testsuite: Support anyhow error chains in error messages.
This is intended to help with adding more usage of anyhow in the testsuite, which can help show context for errors. This also includes some small improvements to the error messages to provide more information.
Configuration menu - View commit details
-
Copy full SHA for 0f5deb6 - Browse repository at this point
Copy the full SHA 0f5deb6View commit details -
Move comparison and diffing code to a new module.
This includes various minor refactorings to try to clean things up and provide better error messages.
Configuration menu - View commit details
-
Copy full SHA for e132bb5 - Browse repository at this point
Copy the full SHA e132bb5View commit details -
It isn't needed anymore, and I would prefer to not keep around unused code. It can always be added back if ever needed again.
Configuration menu - View commit details
-
Copy full SHA for 6dff997 - Browse repository at this point
Copy the full SHA 6dff997View commit details -
Configuration menu - View commit details
-
Copy full SHA for 24b8936 - Browse repository at this point
Copy the full SHA 24b8936View commit details -
Configuration menu - View commit details
-
Copy full SHA for b9f15ab - Browse repository at this point
Copy the full SHA b9f15abView commit details -
Use better high-level interfaces to achieve the same thing.
Configuration menu - View commit details
-
Copy full SHA for b73e3d4 - Browse repository at this point
Copy the full SHA b73e3d4View commit details -
Remove the double-backslash escape for matching.
Using `with_json` is safer since it knows what JSON escaping is.
Configuration menu - View commit details
-
Copy full SHA for aea5ca3 - Browse repository at this point
Copy the full SHA aea5ca3View commit details -
Only normalize paths on windows.
I don't trust that all these transformations won't have unintended consequences on other platforms. It is nice to verify there aren't any backslash shenanigans on other platforms.
Configuration menu - View commit details
-
Copy full SHA for 205148e - Browse repository at this point
Copy the full SHA 205148eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 16b5402 - Browse repository at this point
Copy the full SHA 16b5402View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.