Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't include math for unix and wasi targets #680

Merged
merged 1 commit into from
Aug 28, 2024

Commits on Aug 27, 2024

  1. Don't include math for unix and wasi targets

    This fixes such as (rust-lang/rust#128386)
    where, our implementation is being used on systems where there is
    already `math` library and its more performant and accurate.
    
    So with this change, linux will go back to the previous behavior and not
    include these functions, windows and apple were generally not affected.
    
    Looking at the targets we have builtin now in rust, everything else is
    probably good to have the math symbols.
    
    > A note on the above, the `hermit` os uses `libm` directly for itself,
    > but I think its Ok to keep providing math in `compiler_builtin` for it,
    > its technically the same implementation either from `compiler_builtin`
    > or `hermit-builtins`.
    
    Signed-off-by: Amjad Alsharafi <26300843+Amjad50@users.noreply.github.com>
    Amjad50 committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    0fab77e View commit details
    Browse the repository at this point in the history