Fix nightly dead_code warnings #1533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jyn514
commented
Oct 27, 2021
jyn514
commented
- Remove unused fields for custom repository
- Ignore warnings for deserialized errors. These are actually useful.
- Remove unused fields for custom repository - Ignore warnings for deserialized errors. These are actually useful.
Nemo157
reviewed
Oct 27, 2021
| @@ -205,18 +205,21 @@ struct GraphResponse<T> { | |||
| } | |||
|
|
|||
| #[derive(Debug, Deserialize)] | |||
| #[allow(dead_code)] // used by anyhow for error reporting; apparently the compiler isn't smart enough to tell | |||
There was a problem hiding this comment.
Hmm, that issue doesn't look like it's going to be fixed any time soon. Are you ok with merging these for now?
There was a problem hiding this comment.
Yeah, I think it's more a "intended fallout, won't fix" (though, in cases like this it is slightly plausible that rustc can see through the trait object cast and debug call to see that Debug is used).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.