Auto merge of #3975 - phansch:has_placeholders, r=flip1995

Change while_let_loop applicability to HasPlaceholders The suggestion has been changed at some point to use `..` in the suggested code. Due to that we can't make the lint MachineApplicable anymore. cc #3630
rust-lang · Apr 17, 2019 · 1132caa · 1132caa
2 parents e4eee4b + e974d84
commit 1132caa
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/clippy_lints/src/loops.rs b/clippy_lints/src/loops.rs
@@ -530,12 +530,12 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for Pass {
                                     return;
                                 }
 
-                                // NOTE: we used to make build a body here instead of using
+                                // NOTE: we used to build a body here instead of using
                                 // ellipsis, this was removed because:
                                 // 1) it was ugly with big bodies;
                                 // 2) it was not indented properly;
                                 // 3) it wasn’t very smart (see #675).
-                                let mut applicability = Applicability::MachineApplicable;
+                                let mut applicability = Applicability::HasPlaceholders;
                                 span_lint_and_sugg(
                                     cx,
                                     WHILE_LET_LOOP,