Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

random_state lint #3603

Merged
merged 4 commits into from
Jan 3, 2019
Merged

random_state lint #3603

merged 4 commits into from
Jan 3, 2019

Conversation

KamilaBorowska
Copy link
Contributor

No description provided.

@phansch phansch added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Dec 30, 2018
@phansch
Copy link
Member

phansch commented Jan 2, 2019

@bors r+ thanks!

@bors
Copy link
Collaborator

bors commented Jan 2, 2019

📌 Commit 11b957e has been approved by phansch

bors added a commit that referenced this pull request Jan 2, 2019
@bors
Copy link
Collaborator

bors commented Jan 2, 2019

⌛ Testing commit 11b957e with merge 55adb13...

@bors
Copy link
Collaborator

bors commented Jan 2, 2019

💥 Test timed out

@matthiaskrgr
Copy link
Member

@bors retry

@bors
Copy link
Collaborator

bors commented Jan 3, 2019

⌛ Testing commit 11b957e with merge 0a6593c...

bors added a commit that referenced this pull request Jan 3, 2019
@bors
Copy link
Collaborator

bors commented Jan 3, 2019

☀️ Test successful - status-appveyor, status-travis
Approved by: phansch
Pushing 0a6593c to master...

@bors bors merged commit 11b957e into rust-lang:master Jan 3, 2019
matthiaskrgr added a commit to matthiaskrgr/rust-clippy that referenced this pull request Jan 5, 2019
…sch"

This reverts commit 0a6593c, reversing
changes made to 5277a1f.

This hopefully fixes rust-lang#3628
bors added a commit that referenced this pull request Mar 14, 2019
Run rustfix for string_lit_as_bytes tests

This moves the `string_lit_as_bytes` tests into a new file and enables
rustfix tests for them.

cc #3603, #2038
phansch added a commit to phansch/rust-clippy that referenced this pull request Mar 15, 2019
This moves all `mistyped_literal_suffix` tests to their own file and
enables rustfix tests for them.

cc rust-lang#3603, rust-lang#2038

Based on rust-lang#3887
bors added a commit that referenced this pull request Mar 18, 2019
…nd_rustfix, r=flip1995

Add rustfix tests for mistyped_literal_suffix lint

This moves all `mistyped_literal_suffix` tests to their own file and
enables rustfix tests for them.

cc #3603, #2038

Based on #3887
phansch added a commit to phansch/rust-clippy that referenced this pull request Mar 19, 2019
This moves all `mistyped_literal_suffix` tests to their own file and
enables rustfix tests for them.

cc rust-lang#3603, rust-lang#2038

Based on rust-lang#3887
bors added a commit that referenced this pull request Mar 19, 2019
…nd_rustfix, r=flip1995

Add rustfix tests for mistyped_literal_suffix lint

This moves all `mistyped_literal_suffix` tests to their own file and
enables rustfix tests for them.

cc #3603, #2038

Based on #3887
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request May 5, 2020
Changes:
````
Revert "tests: used_underscore_binding_macro: disable random_state lint."
Revert "Auto merge of rust-lang#3603 - xfix:random-state-lint, r=phansch"
rustup rust-lang/rust#56837
rustup (don't know the exact PR unfortunately)
Add itertools to integration tests
tests: used_underscore_binding_macro: disable random_state lint.
Trigger `use_self` lint in local macros
Add run-rustfix where it already passes
rustup: rust-lang/rust#55517
Make clippy work with parallel rustc
Add ui/for_kv_map test for false positive in rust-lang#1279
Update to latest compiletest-rs release
add testcase for rust-lang#3462
deps: bump rustc_tools_util version from 0.1.0 to 0.1.1 just in case...
Use compiletest's aux-build header instead of include macro
rustc_tool_utils: fix failure to create proper non-repo version string when used in crates on crates.io, bump version
rustfmt
UI test cleanup: Extract ifs_same_cond tests
Extract IteratorFalsePositives into option_helpers.rs
UI test cleanup: Extract for_kv_map lint tests
UI test cleanup: Extract lint from methods.rs test
Fix test for rust-lang/rust#57250
Limit infinite_iter collect() check to known types
Some improvements to util documentation
Use hashset for name blacklist
Reformat random_state tests
Use node_id_to_type_opt instead of node_it_to_type in random_state
Check pattern equality while checking declaration equality
random_state lint
Move constant write checks to temporary_assignment lint
Use an FxHashSet for valid idents in documentation lint
Fix suggestion for unnecessary_ref lint
Update CONTRIBUTING.md for rustfix tests
Update .fixed files via update-references.sh
Run rustfix on first UI test
Use WIP branch for compiletest_rs
````
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants