Make more tests rustfixable #4575

Manishearth · 2019-09-25T12:42:52Z

Fixes #3630

changelog: Improve suggestions for many lints in preparation for cargo fix --clippy

r? @phansch @yaahc

Manishearth · 2019-09-25T17:06:40Z

this PR will grow the longer folks take to review it 🤣

oli-obk

some nits, lgtm otherwise

oli-obk · 2019-09-25T17:16:19Z

clippy_lints/src/entry.rs

                                           snippet(self.cx, self.map.span, "map"),
                                           snippet(self.cx, params[1].span, ".."));

-                        db.span_suggestion(
+                        db.span_help(


use a label, otherwise we get the source printed twice

oli-obk · 2019-09-25T17:22:02Z

clippy_lints/src/needless_borrowed_ref.rs

            then {
+                // do not recurse within patterns, as they may have


comment cut off

oli-obk · 2019-09-25T17:22:16Z

clippy_lints/src/needless_borrowed_ref.rs

+                // do not recurse within patterns, as they may have
+                if let Node::Pat(_) = parent_node {
+                    return;
+                };


oli-obk · 2019-09-25T17:25:01Z

clippy_lints/src/non_copy_const.rs

-                    "static".to_string(),
-                    Applicability::MachineApplicable,
-                );
+                db.span_help(const_kw_span, "make this a static item (maybe with lazy_static)");


use span_label

Manishearth · 2019-09-25T18:08:56Z

Addressed. Need to fix the toolchain now.

Manishearth · 2019-09-25T18:13:23Z

@bors r=oli-obk

unsure if the osx issue has been fixed yet, might as well try

bors · 2019-09-25T18:13:24Z

📌 Commit c778b61 has been approved by oli-obk

@phansch

Make more tests rustfixable Burning through #3630 changelog: Improve suggestions for many lints in preparation for `cargo fix --clippy` r? @phansch @yaahc

bors · 2019-09-25T18:13:32Z

⌛ Testing commit c778b61 with merge a5c705c...

bors · 2019-09-25T18:29:05Z

💔 Test failed - status-appveyor

Manishearth · 2019-09-25T20:40:50Z

@bors r=oli-obk

bors · 2019-09-25T20:40:51Z

📌 Commit 472745c has been approved by oli-obk

bors · 2019-09-25T20:40:52Z

🌲 The tree is currently closed for pull requests below priority 10, this pull request will be tested once the tree is reopened

Manishearth · 2019-09-25T20:53:14Z

@bors treeclosed-

I'm marking OSX as an allowed failure so that we can get a clippyup landed immediately after the cargo update. There's three PRs worth of breakages here and I'd rather not buffer futher, especially since there's another big breakage coming soon.

bors · 2019-09-25T20:53:21Z

⌛ Testing commit 472745c with merge aceab00...

@phansch

Make more tests rustfixable Burning through #3630 changelog: Improve suggestions for many lints in preparation for `cargo fix --clippy` r? @phansch @yaahc

Manishearth · 2019-09-25T20:53:49Z

er, wrong PR

Manishearth · 2019-09-25T20:56:19Z

@bors r=oli-obk

bors · 2019-09-25T20:56:20Z

📌 Commit eb1e9cd has been approved by oli-obk

@phansch

Make more tests rustfixable Burning through #3630 changelog: Improve suggestions for many lints in preparation for `cargo fix --clippy` r? @phansch @yaahc

bors · 2019-09-25T21:42:51Z

⌛ Testing commit eb1e9cd with merge f3e82fc...

Manishearth · 2019-09-25T21:45:35Z

@bors r=oli-obk

bors · 2019-09-25T21:45:36Z

📌 Commit b94f2e8 has been approved by oli-obk

bors · 2019-09-25T21:45:43Z

⌛ Testing commit b94f2e8 with merge 82e96c7...

@phansch

Make more tests rustfixable Burning through #3630 changelog: Improve suggestions for many lints in preparation for `cargo fix --clippy` r? @phansch @yaahc

Manishearth · 2019-09-25T21:53:31Z

@bors r=oli-obk

bors · 2019-09-25T21:53:33Z

📌 Commit 866338e has been approved by oli-obk

bors · 2019-09-25T21:53:40Z

⌛ Testing commit 866338e with merge c8de7c8...

@phansch

Make more tests rustfixable Burning through #3630 changelog: Improve suggestions for many lints in preparation for `cargo fix --clippy` r? @phansch @yaahc

Manishearth · 2019-09-25T21:54:10Z

@bors r=oli-obk

we now fix all the suggestions, updated PR body

bors · 2019-09-25T21:54:11Z

📌 Commit 49374a4 has been approved by oli-obk

@phansch

Make more tests rustfixable Fixes #3630 changelog: Improve suggestions for many lints in preparation for `cargo fix --clippy` r? @phansch @yaahc

bors · 2019-09-25T21:54:19Z

⌛ Testing commit 49374a4 with merge 1366629...

bors · 2019-09-25T22:24:48Z

☀️ Test successful - checks-travis, status-appveyor
Approved by: oli-obk
Pushing 1366629 to master...

Manishearth mentioned this pull request Sep 25, 2019

Tracking Issue: Fixing broken lint suggestions #3630

Closed

39 tasks

Manishearth force-pushed the suggestions branch from 639cf27 to 0cbd51b Compare September 25, 2019 16:33

Manishearth mentioned this pull request Sep 25, 2019

Add run-rustfix for result_map_unit_fn lint #4571

Closed

Manishearth force-pushed the suggestions branch 2 times, most recently from 6408650 to 895c661 Compare September 25, 2019 17:35

oli-obk reviewed Sep 25, 2019

View reviewed changes

Manishearth force-pushed the suggestions branch from 412f1d1 to 926546e Compare September 25, 2019 18:08

Manishearth force-pushed the suggestions branch from 926546e to c778b61 Compare September 25, 2019 18:12

bors added a commit that referenced this pull request Sep 25, 2019

Auto merge of #4575 - Manishearth:suggestions, r=oli-obk

a5c705c

Make more tests rustfixable Burning through #3630 changelog: Improve suggestions for many lints in preparation for `cargo fix --clippy` r? @phansch @yaahc

Manishearth force-pushed the suggestions branch 2 times, most recently from 2bfbb67 to 472745c Compare September 25, 2019 20:40

bors added a commit that referenced this pull request Sep 25, 2019

Auto merge of #4575 - Manishearth:suggestions, r=oli-obk

aceab00

Make more tests rustfixable Burning through #3630 changelog: Improve suggestions for many lints in preparation for `cargo fix --clippy` r? @phansch @yaahc

Remove suggestion for complex map_entry cases

d445bf2

Manishearth force-pushed the suggestions branch from 472745c to eb1e9cd Compare September 25, 2019 20:55

bors added a commit that referenced this pull request Sep 25, 2019

Auto merge of #4575 - Manishearth:suggestions, r=oli-obk

f3e82fc

Make more tests rustfixable Burning through #3630 changelog: Improve suggestions for many lints in preparation for `cargo fix --clippy` r? @phansch @yaahc

Manishearth added 12 commits September 25, 2019 14:45

non_copy_const: remove incorrect suggestion

1090509

map_unit_fn: rename tests to fixable

38a0785

option_map_unit_fn: Split into fixable/unfixable

24c283e

map_unit_fn: fix applicability

ad0e7c8

map_unit_fn: make test rustfixable

e4ff86d

redundant_closure_call: split tests into fixable

a83a8dc

redundant_pattern_matching: make rustfixable

d28dacb

renamed_builtin_attr: make test rustfixable

ea16ab5

redundant_static_lifetimes: split test, make rustfixable

1a4dcfc

string_add, string_add_assign: split tests, make one rustfixable

363e382

unnecessary_clone: split rustfixable lint out into separate test

04dd580

unnecessary_operation: make test rustfixable

b94f2e8

Manishearth force-pushed the suggestions branch from eb1e9cd to b94f2e8 Compare September 25, 2019 21:45

bors added a commit that referenced this pull request Sep 25, 2019

Auto merge of #4575 - Manishearth:suggestions, r=oli-obk

82e96c7

Make more tests rustfixable Burning through #3630 changelog: Improve suggestions for many lints in preparation for `cargo fix --clippy` r? @phansch @yaahc

bors added a commit that referenced this pull request Sep 25, 2019

Auto merge of #4575 - Manishearth:suggestions, r=oli-obk

c8de7c8

Make more tests rustfixable Burning through #3630 changelog: Improve suggestions for many lints in preparation for `cargo fix --clippy` r? @phansch @yaahc

Downgrade op_ref to a MaybeIncorrect suggestion

49374a4

Manishearth force-pushed the suggestions branch from 866338e to 49374a4 Compare September 25, 2019 21:53

bors added a commit that referenced this pull request Sep 25, 2019

Auto merge of #4575 - Manishearth:suggestions, r=oli-obk

1366629

Make more tests rustfixable Fixes #3630 changelog: Improve suggestions for many lints in preparation for `cargo fix --clippy` r? @phansch @yaahc

bors merged commit 49374a4 into rust-lang:master Sep 25, 2019

Manishearth deleted the suggestions branch September 25, 2019 22:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make more tests rustfixable #4575

Make more tests rustfixable #4575

Manishearth commented Sep 25, 2019 •

edited

Loading

Manishearth commented Sep 25, 2019

oli-obk left a comment

oli-obk Sep 25, 2019

oli-obk Sep 25, 2019

oli-obk Sep 25, 2019

oli-obk Sep 25, 2019

Manishearth commented Sep 25, 2019

Manishearth commented Sep 25, 2019

bors commented Sep 25, 2019

bors commented Sep 25, 2019

bors commented Sep 25, 2019

Manishearth commented Sep 25, 2019

bors commented Sep 25, 2019

bors commented Sep 25, 2019

Manishearth commented Sep 25, 2019

bors commented Sep 25, 2019

Manishearth commented Sep 25, 2019

Manishearth commented Sep 25, 2019

bors commented Sep 25, 2019

bors commented Sep 25, 2019

Manishearth commented Sep 25, 2019

bors commented Sep 25, 2019

bors commented Sep 25, 2019

Manishearth commented Sep 25, 2019

bors commented Sep 25, 2019

bors commented Sep 25, 2019

Manishearth commented Sep 25, 2019

bors commented Sep 25, 2019

bors commented Sep 25, 2019

bors commented Sep 25, 2019

Make more tests rustfixable #4575

Make more tests rustfixable #4575

Conversation

Manishearth commented Sep 25, 2019 • edited Loading

Manishearth commented Sep 25, 2019

oli-obk left a comment

Choose a reason for hiding this comment

oli-obk Sep 25, 2019

Choose a reason for hiding this comment

oli-obk Sep 25, 2019

Choose a reason for hiding this comment

oli-obk Sep 25, 2019

Choose a reason for hiding this comment

oli-obk Sep 25, 2019

Choose a reason for hiding this comment

Manishearth commented Sep 25, 2019

Manishearth commented Sep 25, 2019

bors commented Sep 25, 2019

bors commented Sep 25, 2019

bors commented Sep 25, 2019

Manishearth commented Sep 25, 2019

bors commented Sep 25, 2019

bors commented Sep 25, 2019

Manishearth commented Sep 25, 2019

bors commented Sep 25, 2019

Manishearth commented Sep 25, 2019

Manishearth commented Sep 25, 2019

bors commented Sep 25, 2019

bors commented Sep 25, 2019

Manishearth commented Sep 25, 2019

bors commented Sep 25, 2019

bors commented Sep 25, 2019

Manishearth commented Sep 25, 2019

bors commented Sep 25, 2019

bors commented Sep 25, 2019

Manishearth commented Sep 25, 2019

bors commented Sep 25, 2019

bors commented Sep 25, 2019

bors commented Sep 25, 2019

Manishearth commented Sep 25, 2019 •

edited

Loading