-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the release process with Twitter instructions #517
Open
pietroalbini
wants to merge
3
commits into
rust-lang:master
Choose a base branch
from
pietroalbini:twitter
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is too high a bar. I think sending a ping makes sense, but I don't think that we should block on the response. The twitter post is not a critical part of the release, IMO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both of us doing releases can log into the Twitter account, so even if we can't reach out who usually tweets stuff from the account we should be able to post a tweet on our own.
I personally consider tweets to be the way we publicly announce the release is out, along with the blog post, so I'd say we should make sure we have a tweet out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, I guess that's true in some sense, but I also don't see it as critical that we do announce a new release in a push fashion. It makes sense for the release blog post to go out, but the tweet being "late" doesn't seem like a problem to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have examples in mind of cases where we wouldn't be able to post the tweet? I can't personally think of any, but I'm probably missing something :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally don't really post on Twitter at all, and while I could learn to do so, I think posting the tweet is not necessary for a release to happen; it adds additional complexity.
Part of this is that in the future I'd like to get us to a point where the release is even more hands off than today, and while Twitter does have an API etc, I'm much more hesitant about letting bots post to our twitter than tagging commits and such.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if we get to a point where posting the tweet is one of the only manual steps we can reconsider, but for now I'd prefer if we keep tweeting as part of our regular checklist.
I could see us automating tweeting as part of merging blog posts in the future, so the automation doesn't really have to be specific to the release process. Personally I think we're still far from that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I'll be honest, I don't want to learn to push the right buttons and login to 1password, then twitter, etc. for each release I run; I don't consider the tweet anywhere near high priority enough for that to be necessary to execute on the release. I think it should happen, yes, but if it happens +0 or +N hours from the actual release seems unimportant to me... I'm trying to understand why you seem to think differently, but so far don't think I've heard concrete arguments. It feels clear to me that announcing the release and actually running it need not be coupled.