-
Notifications
You must be signed in to change notification settings - Fork 12.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Warn/error on self ctor from outer item in inner item
- Loading branch information
1 parent
f9b1614
commit c052858
Showing
10 changed files
with
195 additions
and
83 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,12 @@ | ||
struct A<B>(B); | ||
impl<B>A<B>{fn d(){fn d(){Self(1)}}} | ||
//~^ ERROR the size for values of type `B` cannot be known at compilation time | ||
//~| ERROR the size for values of type `B` cannot be known at compilation time | ||
//~| ERROR mismatched types | ||
//~| ERROR mismatched types | ||
//~| ERROR `main` function not found in crate | ||
|
||
impl<B> A<B> { | ||
fn d() { | ||
fn d() { | ||
Self(1) | ||
//~^ ERROR can't reference `Self` constructor from outer item | ||
} | ||
} | ||
} | ||
|
||
fn main() {} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,79 +1,12 @@ | ||
error[E0601]: `main` function not found in crate `do_not_ice_on_note_and_explain` | ||
--> $DIR/do-not-ice-on-note_and_explain.rs:2:37 | ||
error[E0401]: can't reference `Self` constructor from outer item | ||
--> $DIR/do-not-ice-on-note_and_explain.rs:6:13 | ||
| | ||
LL | impl<B>A<B>{fn d(){fn d(){Self(1)}}} | ||
| ^ consider adding a `main` function to `$DIR/do-not-ice-on-note_and_explain.rs` | ||
LL | impl<B> A<B> { | ||
| ------------ the inner item doesn't inherit generics from this impl, so `Self` is invalid to reference | ||
... | ||
LL | Self(1) | ||
| ^^^^ help: replace `Self` with the actual type: `A` | ||
|
||
error[E0277]: the size for values of type `B` cannot be known at compilation time | ||
--> $DIR/do-not-ice-on-note_and_explain.rs:2:32 | ||
| | ||
LL | impl<B>A<B>{fn d(){fn d(){Self(1)}}} | ||
| - ---- ^ doesn't have a size known at compile-time | ||
| | | | ||
| | required by a bound introduced by this call | ||
| this type parameter needs to be `Sized` | ||
| | ||
note: required by a bound in `A` | ||
--> $DIR/do-not-ice-on-note_and_explain.rs:1:10 | ||
| | ||
LL | struct A<B>(B); | ||
| ^ required by this bound in `A` | ||
|
||
error[E0308]: mismatched types | ||
--> $DIR/do-not-ice-on-note_and_explain.rs:2:32 | ||
| | ||
LL | impl<B>A<B>{fn d(){fn d(){Self(1)}}} | ||
| ---- ^ expected type parameter `B`, found integer | ||
| | | ||
| arguments to this function are incorrect | ||
| | ||
= note: expected type parameter `B` | ||
found type `{integer}` | ||
note: tuple struct defined here | ||
--> $DIR/do-not-ice-on-note_and_explain.rs:1:8 | ||
| | ||
LL | struct A<B>(B); | ||
| ^ | ||
|
||
error[E0308]: mismatched types | ||
--> $DIR/do-not-ice-on-note_and_explain.rs:2:27 | ||
| | ||
LL | impl<B>A<B>{fn d(){fn d(){Self(1)}}} | ||
| ^^^^^^^ expected `()`, found `A<B>` | ||
| | ||
= note: expected unit type `()` | ||
found struct `A<B>` | ||
help: consider using a semicolon here | ||
| | ||
LL | impl<B>A<B>{fn d(){fn d(){Self(1);}}} | ||
| + | ||
help: try adding a return type | ||
| | ||
LL | impl<B>A<B>{fn d(){fn d() -> A<B>{Self(1)}}} | ||
| +++++++ | ||
|
||
error[E0277]: the size for values of type `B` cannot be known at compilation time | ||
--> $DIR/do-not-ice-on-note_and_explain.rs:2:27 | ||
| | ||
LL | impl<B>A<B>{fn d(){fn d(){Self(1)}}} | ||
| - ^^^^^^^ doesn't have a size known at compile-time | ||
| | | ||
| this type parameter needs to be `Sized` | ||
| | ||
note: required by an implicit `Sized` bound in `A` | ||
--> $DIR/do-not-ice-on-note_and_explain.rs:1:10 | ||
| | ||
LL | struct A<B>(B); | ||
| ^ required by the implicit `Sized` requirement on this type parameter in `A` | ||
help: you could relax the implicit `Sized` bound on `B` if it were used through indirection like `&B` or `Box<B>` | ||
--> $DIR/do-not-ice-on-note_and_explain.rs:1:10 | ||
| | ||
LL | struct A<B>(B); | ||
| ^ - ...if indirection were used here: `Box<B>` | ||
| | | ||
| this could be changed to `B: ?Sized`... | ||
|
||
error: aborting due to 5 previous errors | ||
error: aborting due to 1 previous error | ||
|
||
Some errors have detailed explanations: E0277, E0308, E0601. | ||
For more information about an error, try `rustc --explain E0277`. | ||
For more information about this error, try `rustc --explain E0401`. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
warning: can't reference `Self` constructor from outer item | ||
--> $DIR/self-ctor-nongeneric.rs:8:23 | ||
| | ||
LL | impl S0 { | ||
| ------- the inner item doesn't inherit generics from this impl, so `Self` is invalid to reference | ||
LL | fn foo() { | ||
LL | const C: S0 = Self(0); | ||
| ^^^^ help: replace `Self` with the actual type: `S0` | ||
| | ||
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! | ||
= note: for more information, see issue #124186 <https://github.com/rust-lang/rust/issues/124186> | ||
= note: `#[warn(self_constructor_from_outer_item)]` on by default | ||
|
||
warning: can't reference `Self` constructor from outer item | ||
--> $DIR/self-ctor-nongeneric.rs:12:13 | ||
| | ||
LL | impl S0 { | ||
| ------- the inner item doesn't inherit generics from this impl, so `Self` is invalid to reference | ||
... | ||
LL | Self(0) | ||
| ^^^^ help: replace `Self` with the actual type: `S0` | ||
| | ||
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! | ||
= note: for more information, see issue #124186 <https://github.com/rust-lang/rust/issues/124186> | ||
|
||
warning: 2 warnings emitted | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
struct S0<T>(T); | ||
|
||
impl<T> S0<T> { | ||
fn foo() { | ||
const C: S0<i32> = Self(0); | ||
//~^ ERROR can't reference `Self` constructor from outer item | ||
fn bar() -> S0<i32> { | ||
Self(0) | ||
//~^ ERROR can't reference `Self` constructor from outer item | ||
} | ||
} | ||
} | ||
|
||
fn main() {} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
error[E0401]: can't reference `Self` constructor from outer item | ||
--> $DIR/self-ctor.rs:5:28 | ||
| | ||
LL | impl<T> S0<T> { | ||
| ------------- the inner item doesn't inherit generics from this impl, so `Self` is invalid to reference | ||
LL | fn foo() { | ||
LL | const C: S0<i32> = Self(0); | ||
| ^^^^ help: replace `Self` with the actual type: `S0` | ||
|
||
error[E0401]: can't reference `Self` constructor from outer item | ||
--> $DIR/self-ctor.rs:8:13 | ||
| | ||
LL | impl<T> S0<T> { | ||
| ------------- the inner item doesn't inherit generics from this impl, so `Self` is invalid to reference | ||
... | ||
LL | Self(0) | ||
| ^^^^ help: replace `Self` with the actual type: `S0` | ||
|
||
error: aborting due to 2 previous errors | ||
|
||
For more information about this error, try `rustc --explain E0401`. |