-
Notifications
You must be signed in to change notification settings - Fork 12.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
path: Fix joining Windows path when the receiver is "C:"
WindowsPath::new("C:").join("a") produces r"C:\a". This is incorrect. It should produce "C:a".
- Loading branch information
Showing
1 changed file
with
9 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c57920b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from erickt
at lilyball@c57920b
c57920b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging kballard/rust/windows-path-join = c57920b into auto
c57920b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kballard/rust/windows-path-join = c57920b merged ok, testing candidate = 6361c1d
c57920b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/3587
success: http://buildbot.rust-lang.org/builders/auto-mac-32-nopt-c/builds/1430
success: http://buildbot.rust-lang.org/builders/auto-mac-32-nopt-t/builds/1432
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/3588
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/2689
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/2694
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/3603
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/2691
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/2697
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/3605
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/2691
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/2696
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android/builds/2765
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/3595
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/2696
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/2701
success: http://buildbot.rust-lang.org/builders/auto-bsd-64-opt/builds/3366
c57920b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = 6361c1d