Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump minimum OS X version to 10.7 #11927

Closed
thestinger opened this issue Jan 30, 2014 · 4 comments
Closed

bump minimum OS X version to 10.7 #11927

thestinger opened this issue Jan 30, 2014 · 4 comments
Labels
O-macos Operating system: macOS

Comments

@thestinger
Copy link
Contributor

Rust is currently broken on 10.6 due to #10842, and there does not appear to be interest in fixing it. The version in the README should be increased if it's not going to be supported anymore.

Apple does not appear to support Snow Leopard anymore and I don't see a reason to continue support for an OS without security updates.
@thestinger
Copy link
Contributor Author

cc @brson

@brson
Copy link
Contributor

brson commented Jan 30, 2014

I'm ok with it. If somebody needs 0.6 support it still isn't that hard to add back. Anybody else have opinions? @pcwalton?

@alexcrichton
Copy link
Member

I'm fine with bumping to 10.7, but I also haven't had a 10.6 machine in ages so I may be biased.

@brson
Copy link
Contributor

brson commented Jan 30, 2014

I do have a 10.6 machine, but I haven't used it since Rust has been broken.

@briansmith briansmith mentioned this issue Mar 12, 2016
Closed
@phil-blain phil-blain mentioned this issue Dec 26, 2020
Merged
@thomcc thomcc mentioned this issue Dec 8, 2021
Open
flip1995 pushed a commit to flip1995/rust that referenced this issue Feb 26, 2024
@Ethiraric
[box_default]: Preserve required path segments
97dc4b2 
When encountering code such as:
```
Box::new(outer::Inner::default())
```
clippy would suggest replacing with `Box::<Inner>::default()`, dropping
the `outer::` segment. This behavior is incorrect and that commit fixes
it.

What it does is it checks the contents of the `Box::new` and, if it is
of the form `A::B::default`, does a text replacement, inserting `A::B`
in the `Box`'s quickfix generic list.
If the source does not match that pattern (including `Vec::from(..)`
or other `T::new()` calls), we then fallback to the original code.

Fixes rust-lang#11927
flip1995 pushed a commit to flip1995/rust that referenced this issue Feb 26, 2024
@bors
Auto merge of rust-lang#12355 - Ethiraric:fix-11927, r=Alexendoo
d718995 
[`box_default`]: Preserve required path segments

When encountering code such as:
```rs
Box::new(outer::Inner::default())
```
clippy would suggest replacing with `Box::<Inner>::default()`, dropping the `outer::` segment. This behavior is incorrect and that commit fixes it.

What it does is it checks the contents of the `Box::new` and, if it is of the form `A::B::default`, does a text replacement, inserting `A::B` in the `Box`'s quickfix generic list.
If the source does not match that pattern (including `Vec::from(..)` or other `T::new()` calls), we then fallback to the original code.

Fixes rust-lang#11927

*Please write a short comment explaining your change (or "none" for internal only changes)*

changelog: [`box_default`]: Preserve required path segments
@clubby789 clubby789 mentioned this issue Jun 10, 2024
Open
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
O-macos Operating system: macOS
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexcrichton @brson @thestinger