Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc collapser also collapses stability annotations #121772

Closed
Gankra opened this issue Feb 29, 2024 · 1 comment · Fixed by #121855
Closed

rustdoc collapser also collapses stability annotations #121772

Gankra opened this issue Feb 29, 2024 · 1 comment · Fixed by #121855
Assignees
@GuillaumeGomez
Labels
C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@Gankra
Copy link
Contributor

Gankra commented Feb 29, 2024

The stability annotations are inside the collapsible area now, so they get hidden when you collapse things. This is probably undesirable.

Evidently this is a regression introduced in 1.54.0.

Reproduction Steps

tap the [-] in the top right (or if you had it on [+] you need to press it twice)
then check if you can tell which methods are unstable:

image
@Gankra Gankra added the C-bug Category: This is a bug. label Feb 29, 2024
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Feb 29, 2024
@jieyouxu jieyouxu added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Feb 29, 2024
@GuillaumeGomez
Copy link
Member

Quite the old change. But I agree, it should not be foldable.

@GuillaumeGomez GuillaumeGomez self-assigned this Feb 29, 2024
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Mar 1, 2024
@GuillaumeGomez
Add regression test for rust-lang#121772
05f1133
@GuillaumeGomez GuillaumeGomez mentioned this issue Mar 1, 2024
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Mar 1, 2024
@GuillaumeGomez
Add regression test for rust-lang#121772
b119189
@bors bors closed this as completed in 240d0ad Mar 2, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Mar 2, 2024
@rust-timer
Unrolled build for rust-lang#121855
9d1c776 
Rollup merge of rust-lang#121855 - GuillaumeGomez:trait-item-info, r=notriddle

Correctly generate item info of trait items

Fixes rust-lang#121772.

The `document_info` function was wrongly used when documenting a trait item.

r? `@notriddle`
Gankra pushed a commit to Gankra/rust that referenced this issue Mar 3, 2024
@GuillaumeGomez @Gankra
Add regression test for rust-lang#121772
3d87abf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GuillaumeGomez GuillaumeGomez

Labels
C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correctly generate item info of trait items GuillaumeGomez/rust
4 participants
@Gankra @GuillaumeGomez @jieyouxu @rustbot