Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: search for type alias says "type X not found, showing type X instead" #125993

Closed
CAD97 opened this issue Jun 4, 2024 · 0 comments · Fixed by #126176
Closed

rustdoc: search for type alias says "type X not found, showing type X instead" #125993

CAD97 opened this issue Jun 4, 2024 · 0 comments · Fixed by #126176
Assignees
@notriddle
Labels
A-rustdoc-search Area: Rustdoc's search feature A-rustdoc-ui Area: Rustdoc UI (generated HTML) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@CAD97
Copy link
Contributor

CAD97 commented Jun 4, 2024

The "In Names" search tab is fine, but the "In Parameters" and "In Return Types" have the confusing note that e.g.

Type "pid_t" not found. Showing results for closest type name "pid_t" instead.

screenshot

@rustbot label: +T-rustdoc +A-rustdoc-ui
@rustbot rustbot added needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. A-rustdoc-ui Area: Rustdoc UI (generated HTML) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jun 4, 2024
@fmease fmease added A-rustdoc-search Area: Rustdoc's search feature and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Jun 4, 2024
@notriddle notriddle mentioned this issue Jun 8, 2024
Merged
@notriddle notriddle self-assigned this Jun 8, 2024
bors added a commit to rust-lang-ci/rust that referenced this issue Jun 9, 2024
@bors
Auto merge of rust-lang#126176 - notriddle:notriddle/fix-type-name-no…
a47d1e2 
…rmalize, r=fmease

rustdoc-search: use lowercase, non-normalized name for type search

The type name ID map has underscores in its names, so the query element should have them, too.

Fixes rust-lang#125993
jieyouxu added a commit to jieyouxu/rust that referenced this issue Jun 9, 2024
@jieyouxu
Rollup merge of rust-lang#126176 - notriddle:notriddle/fix-type-name-…
4f67f3c 
…normalize, r=fmease

rustdoc-search: use lowercase, non-normalized name for type search

The type name ID map has underscores in its names, so the query element should have them, too.

Fixes rust-lang#125993
@bors bors closed this as completed in 1fb4805 Jun 9, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Jun 9, 2024
@rust-timer
Unrolled build for rust-lang#126176
99f9c94 
Rollup merge of rust-lang#126176 - notriddle:notriddle/fix-type-name-normalize, r=fmease

rustdoc-search: use lowercase, non-normalized name for type search

The type name ID map has underscores in its names, so the query element should have them, too.

Fixes rust-lang#125993
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@notriddle notriddle

Labels
A-rustdoc-search Area: Rustdoc's search feature A-rustdoc-ui Area: Rustdoc UI (generated HTML) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rustdoc-search: use lowercase, non-normalized name for type search notriddle/rust
4 participants
@notriddle @CAD97 @fmease @rustbot