Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llvm-config sometimes doesn't provide the correct include directory #1311

Closed
brson opened this issue Dec 15, 2011 · 10 comments
Closed

llvm-config sometimes doesn't provide the correct include directory #1311

brson opened this issue Dec 15, 2011 · 10 comments
Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. O-windows Operating system: Windows

Comments

@brson
Copy link
Contributor

brson commented Dec 15, 2011

llvm-config --cxxflags looks like this for me:

-I/home/banderson/Dev/rust/src/llvm/include -I/home/banderson/Dev/rust/build/llvm/x86_64-unknown-linux-gnu/include  -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -O3 -fomit-frame-pointer -fno-exceptions -fno-rtti -fPIC -Woverloaded-virtual -Wcast-qual

Critically, our build depends on that first include directory, under the source tree, for rustllvm. In some environments llvm-config doesn't give us that information, probably because it isn't realizing that it's being run out of the build directory.

@brson
Copy link
Contributor Author

brson commented Dec 15, 2011

There's a hack in mk/rustllvm.mk that adds it manually on windows. should be removed when we figure this out.

@ghost ghost assigned brson Apr 12, 2012
@emberian
Copy link
Member

Still relevant.

@catamorphism
Copy link
Contributor

Triage bump. I still see the hack, but don't know how to make progress with this.

@reem
Copy link
Contributor

reem commented Sep 3, 2014

Triage. Hack still there, also unsure how to progress.

@steveklabnik
Copy link
Member

Triage: same as what @reem said.

@steveklabnik
Copy link
Member

Over a year later, my triage estimate is the same as it was last year.

@arielb1
Copy link
Contributor

arielb1 commented Aug 8, 2016

triage: ?

@kyrias
Copy link
Contributor

kyrias commented Aug 26, 2016

Does anyone have a short example for reproducing this?

@joelgallant
Copy link
Contributor

There's a hack in mk/rustllvm.mk that adds it manually on windows. should be removed when we figure this out.

@brson with the makefiles gone, is this still an issue or should this be looked into?

@alexcrichton
Copy link
Member

Indeed I think this is no longer relevant!

bjorn3 added a commit to bjorn3/rust that referenced this issue Jul 22, 2023
coastalwhite pushed a commit to coastalwhite/rust that referenced this issue Aug 5, 2023
This allows using feature detection macros, without placing a
requirement of enabled stdsimd feature gate from end users.

A follow-up to changes from rust-lang#1311, which introduced the new macro.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. O-windows Operating system: Windows
Projects
None yet
Development

No branches or pull requests

9 participants