Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

librustc and libsyntax documentation built only during make install #13728

Closed
SiegeLord opened this issue Apr 24, 2014 · 8 comments
Closed

librustc and libsyntax documentation built only during make install #13728

SiegeLord opened this issue Apr 24, 2014 · 8 comments
Labels
P-medium Medium priority

Comments

@SiegeLord
Copy link
Contributor

And, since make install is often ran as a root, this leads to root-owned documentation.
@brson
Copy link
Contributor

brson commented Apr 25, 2014

Nice catch. I kind of think we should just bite the bullet and always build the rustc docs, even though they take quite a while.

@brson
Copy link
Contributor

brson commented Apr 25, 2014

Maybe there is some low-hanging perf fruit in rustdoc.

@brson brson added A-build and removed A-build labels Apr 25, 2014
@SiegeLord SiegeLord mentioned this issue May 26, 2014
Closed
@brson
Copy link
Contributor

brson commented Aug 21, 2014

Nominating. This is a pretty embarrassing bug that hits anybody that follows the instructions for building and installing.

@pnkfelix
Copy link
Member

P-high, not 1.0 milestone.

@brson
Copy link
Contributor

brson commented Sep 5, 2014

Consensus I recall is to just build all the docs during 'make'.

@lilyball
Copy link
Contributor

lilyball commented Sep 5, 2014

We could presumably change the install rule to detect if we're running as root and if there's a $SUDO_UID env var, build everything with sudo -u \#$SUDO_UID, and then only do the actual install as root.

I think it's a better appoach anyway because this way someone who does ./configure; sudo make install doesn't get everything built as sudo.

lilyball added a commit to lilyball/rust that referenced this issue Sep 5, 2014
@lilyball
Avoid building as root with sudo make install
23c2661 
When running `sudo make install`, we only want to run the actual install
as root, the building of the documentation and the distribution folder
should happen as the non-root user.

Related to rust-lang#13728.
@lilyball lilyball mentioned this issue Sep 5, 2014
Merged
@lilyball
Copy link
Contributor

lilyball commented Sep 5, 2014

PR #17009 makes sudo make install build the distribution (and therefore the documentation) as the non-root user. This fixes the permissions issues. I don't know if that's good enough, or if there's still a motivation to build the docs with make for other reasons.

bors added a commit that referenced this issue Oct 17, 2014
@bors
auto merge of #17009 : kballard/rust/install_no_sudo, r=pnkfelix
9b80efd 
When running `sudo make install`, we only want to run the actual install
as root, the building of the documentation and the distribution folder
should happen as the non-root user.

Related to #13728.
@brson
Copy link
Contributor

brson commented Jan 13, 2015

Considering this fixed.

@brson brson closed this as completed Jan 13, 2015
arcnmx pushed a commit to arcnmx/rust that referenced this issue Dec 17, 2022
@bors
Auto merge of rust-lang#13728 - detrumi:chalk-update, r=lnicola
f9bd487 
Update to Chalk 88

This Chalk release introduces fuel for the recursive solver ([chalk#774](rust-lang/chalk#774)).
I'm not sure how often it calls `should_continue` compared to the other solver, so we might want to increase `CHALK_SOLVER_FUEL`, the current default value of 100 might be too low.

This should fix a lot of hangs and crashes, for example this solves the hang in rust-lang#12897.
@ehuss ehuss mentioned this issue May 7, 2024
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P-medium Medium priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@lilyball @brson @pnkfelix @SiegeLord